repo stringclasses 21
values | pull_number float64 45 194k | instance_id stringlengths 16 34 | issue_numbers stringlengths 6 27 | base_commit stringlengths 40 40 | patch stringlengths 263 270k | test_patch stringlengths 312 408k | problem_statement stringlengths 38 47.6k | hints_text stringlengths 1 257k ⌀ | created_at stringdate 2016-01-11 17:37:29 2024-10-18 14:52:41 | language stringclasses 4
values | Dockerfile stringclasses 279
values | P2P stringlengths 2 10.2M | F2P stringlengths 11 38.9k | F2F stringclasses 86
values | test_command stringlengths 27 11.4k | task_category stringclasses 5
values | is_no_nodes bool 2
classes | is_func_only bool 2
classes | is_class_only bool 2
classes | is_mixed bool 2
classes | num_func_changes int64 0 238 | num_class_changes int64 0 70 | num_nodes int64 0 264 | is_single_func bool 2
classes | is_single_class bool 2
classes | modified_nodes stringlengths 2 42.2k |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
apache/dubbo | 4,567 | apache__dubbo-4567 | ['4551'] | c304bf356c2ed9b228d017b289475aa7f7940eba | diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/Version.java
@@ -100,7 +100,7 @@ public static boo... | diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/version/VersionTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/version/Versio... | Optimize Version#isRelease263OrHigher check
### Environment
* Dubbo version: 2.7.2
* Operating System version: MacOS
* Java version: 1.8
### Steps to reproduce this issue
We have internal dubbo version 2.6.2.1 which bases dubbo-2.6.2。
1. Consumer side dubbo version is 2.6.2.1
2. Provider side dubbo version i... | null | 2019-07-15 00:50:09+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=VersionTest -DfailIfNoTests=false -fae -DskipTes... | ['org.apache.dubbo.common.version.VersionTest.testSupportResponseAttachment', 'org.apache.dubbo.common.version.VersionTest.testIsFramework270OrHigher', 'org.apache.dubbo.common.version.VersionTest.testGetIntVersion', 'org.apache.dubbo.common.version.VersionTest.testGetProtocolVersion'] | ['org.apache.dubbo.common.version.VersionTest.testIsFramework263OrHigher'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=VersionTest -DfailIfNoTests=false -fae surefir... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["dubbo-common/src/main/java/org/apache/dubbo/common/Version.java->program->class_declaration:Version->method_declaration:isSupportResponseAttachment"] |
apache/dubbo | 6,351 | apache__dubbo-6351 | ['6350'] | 1e51703f8f2d8932b839380fe1d24aa584dc0b4e | diff --git a/dubbo-configcenter/dubbo-configcenter-consul/src/main/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfiguration.java b/dubbo-configcenter/dubbo-configcenter-consul/src/main/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfiguration.java
--- a/dubbo-configcenter/dubbo-configcenter-consu... | diff --git a/dubbo-configcenter/dubbo-configcenter-consul/src/test/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfigurationTest.java b/dubbo-configcenter/dubbo-configcenter-consul/src/test/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfigurationTest.java
--- a/dubbo-configcenter/dubbo-configcent... | [Bug]Consul config center can not publish config correncly
The code of Method publishConfig of Class ConsulDynamicConfiguration:
```java
@Override
public boolean publishConfig(String key, String group, String content) throws UnsupportedOperationException {
String normalizedKey = convertKey(group, ke... | null | 2020-06-19 15:57:19+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=ConsulDynamicConfigurationTest -DfailIfNoTests=f... | ['org.apache.dubbo.configcenter.consul.ConsulDynamicConfigurationTest.testAddListener', 'org.apache.dubbo.configcenter.consul.ConsulDynamicConfigurationTest.testGetConfig', 'org.apache.dubbo.configcenter.consul.ConsulDynamicConfigurationTest.testGetConfigKeys'] | ['org.apache.dubbo.configcenter.consul.ConsulDynamicConfigurationTest.testPublishConfig'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=ConsulDynamicConfigurationTest -DfailIfNoTests... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["dubbo-configcenter/dubbo-configcenter-consul/src/main/java/org/apache/dubbo/configcenter/consul/ConsulDynamicConfiguration.java->program->class_declaration:ConsulDynamicConfiguration->method_declaration:publishConfig"] |
apache/rocketmq | 3,862 | apache__rocketmq-3862 | ['3859'] | 35c95eb7a67820f25de8471e50e9988c85a8dc04 | diff --git a/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java b/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java
--- a/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java
+++ b/store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java
@@ -17,11 +17,15 ... | diff --git a/store/src/test/java/org/apache/rocketmq/store/StoreStatsServiceTest.java b/store/src/test/java/org/apache/rocketmq/store/StoreStatsServiceTest.java
--- a/store/src/test/java/org/apache/rocketmq/store/StoreStatsServiceTest.java
+++ b/store/src/test/java/org/apache/rocketmq/store/StoreStatsServiceTest.java
@... | enhance the cal of latency for putting message
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
Now the message putting latency is only counted in the following ranges：
```java
"[<=0ms]", "[0~10ms]", "[10~50ms]", "[50~100ms]", "[100~200ms]", "[200~500ms]", "[500ms~1s]", "[1~2s]", "[2~3s]", "... | null | 2022-02-18 07:59:10+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.store.StoreStatsServiceTest.findPutMessageEntireTimePXTest', 'org.apache.rocketmq.store.StoreStatsServiceTest.getSinglePutMessageTopicTimesTotal', 'org.apache.rocketmq.store.StoreStatsServiceTest.getSinglePutMessageTopicSizeTotal'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=StoreStatsServiceTest -DfailIfNoTests=false -fae surefire-report:rep... | Feature | false | false | false | true | 6 | 2 | 8 | false | false | ["store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java->program->class_declaration:StoreStatsService->method_declaration:incPutMessageEntireTime", "store/src/main/java/org/apache/rocketmq/store/StoreStatsService.java->program->class_declaration:StoreStatsService->method_declaration:getRuntimeInfo", "sto... |
apache/rocketmq | 1,636 | apache__rocketmq-1636 | ['1110'] | 44569e4df6620fff61e43d782815f93a97e748ea | diff --git a/client/src/main/java/org/apache/rocketmq/client/Validators.java b/client/src/main/java/org/apache/rocketmq/client/Validators.java
--- a/client/src/main/java/org/apache/rocketmq/client/Validators.java
+++ b/client/src/main/java/org/apache/rocketmq/client/Validators.java
@@ -33,6 +33,7 @@ public class Valida... | diff --git a/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java b/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
--- a/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/ValidatorsTest.java
@@ -71,13 +71,13 @@ p... | topic length between 128 and 255
1. describe : Why are these Two checks different? Whether there are errors when the length of the topic is between 128 and 255
2. What did you see instead?
2.1. send message
org.apache.rocketmq.client.Validators#checkTopic
` if (topic.length() > CHARACTER_MAX_LENGTH) { //255
... | null | 2019-12-04 10:03:47+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.client.ValidatorsTest.testCheckTopic_TooLongTopic', 'org.apache.rocketmq.client.ValidatorsTest.testCheckTopic_HasIllegalCharacters', 'org.apache.rocketmq.client.ValidatorsTest.testCheckTopic_Success', 'org.apache.rocketmq.client.ValidatorsTest.testCheckTopic_BlankTopic', 'org.apache.rocketmq.clien... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=ValidatorsTest -DfailIfNoTests=false -fae surefire-report:report -Ds... | Bug Fix | false | false | false | true | 1 | 1 | 2 | false | false | ["client/src/main/java/org/apache/rocketmq/client/Validators.java->program->class_declaration:Validators", "client/src/main/java/org/apache/rocketmq/client/Validators.java->program->class_declaration:Validators->method_declaration:checkTopic"] |
apache/rocketmq | 6,455 | apache__rocketmq-6455 | ['6454'] | 9b97eaf5ba8468dcd4b0d695f1de1e8f29170618 | diff --git a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredDispatcher.java b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredDispatcher.java
--- a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredDispatcher.java
+++ b/tieredstore/src/main/java/org/apache/rocketmq/tiereds... | diff --git a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredDispatcherTest.java b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredDispatcherTest.java
--- a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredDispatcherTest.java
+++ b/tieredstore/src/test/java/org/apache/rock... | Fix unsafe shutdown process in tiered storage
Fix the risk of a potential JVM crash, see https://github.com/apache/rocketmq/actions/runs/4498498448/jobs/7915190340?pr=6452 for further information.
| null | 2023-03-23 09:24:59+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.tieredstore.TieredMessageFetcherTest.testGetOffsetInQueueByTime', 'org.apache.rocketmq.tieredstore.TieredMessageFetcherTest.testGetMessageAsync', 'org.apache.rocketmq.tieredstore.TieredDispatcherTest.testDispatchByMQContainer', 'org.apache.rocketmq.tieredstore.container.TieredContainerManagerTest.... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=TieredMessageStoreTest,TieredMessageFetcherTest,TieredDispatcherTest... | Bug Fix | false | false | false | true | 13 | 5 | 18 | false | false | ["tieredstore/src/main/java/org/apache/rocketmq/tieredstore/container/TieredIndexFile.java->program->class_declaration:TieredIndexFile->method_declaration:initFile", "tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredDispatcher.java->program->class_declaration:TieredDispatcher->method_declaration:dispatch... |
apache/rocketmq | 5,008 | apache__rocketmq-5008 | ['4999'] | a5d07e106af81eb1e36d750e1f0d0832a8ea8b3d | diff --git a/srvutil/src/main/java/org/apache/rocketmq/srvutil/ConcurrentHashMapUtil.java b/common/src/main/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtils.java
similarity index 77%
rename from srvutil/src/main/java/org/apache/rocketmq/srvutil/ConcurrentHashMapUtil.java
rename to common/src/main/java/org/a... | diff --git a/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java b/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java
new file mode 100644
--- /dev/null
+++ b/common/src/test/java/org/apache/rocketmq/common/utils/ConcurrentHashMapUtilsTest.java
@@ -0,... | ConcurrentHashMap#computeIfAbsent have performance problem in jdk1.8 QueueOffsetAssigner#assignQueueOffset use it.
[openjdk bug report](https://bugs.openjdk.org/browse/JDK-8161372) .
use JMH to test it:
`... | Good catch. Do you have the plan to fix it?
> Good catch. Do you have the plan to fix it?
I will submit a PR to fix it | 2022-09-06 15:28:16+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.common.utils.ConcurrentHashMapUtilsTest.computeIfAbsent'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=ConcurrentHashMapUtilsTest -DfailIfNoTests=false -fae surefire-repor... | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | ["proxy/src/main/java/org/apache/rocketmq/proxy/processor/ReceiptHandleProcessor.java->program->class_declaration:ReceiptHandleProcessor->method_declaration:addReceiptHandle", "proxy/src/main/java/org/apache/rocketmq/proxy/service/channel/ChannelManager.java->program->class_declaration:ChannelManager->method_declaratio... |
apache/dubbo | 4,170 | apache__dubbo-4170 | ['4147'] | 9168543d855f287720fcd257f68ee0acccb95170 | diff --git a/dubbo-metadata-report/dubbo-metadata-report-api/src/main/java/org/apache/dubbo/metadata/identifier/MetadataIdentifier.java b/dubbo-metadata-report/dubbo-metadata-report-api/src/main/java/org/apache/dubbo/metadata/identifier/MetadataIdentifier.java
--- a/dubbo-metadata-report/dubbo-metadata-report-api/src/m... | diff --git a/dubbo-metadata-report/dubbo-metadata-report-api/src/test/java/org/apache/dubbo/metadata/identifier/MetadataIdentifierTest.java b/dubbo-metadata-report/dubbo-metadata-report-api/src/test/java/org/apache/dubbo/metadata/identifier/MetadataIdentifierTest.java
--- a/dubbo-metadata-report/dubbo-metadata-report-a... | [Bug]Metadata Store Key was changed so that it is not compatible with 2.7.1
Metadata Store Key was changed so that it is not compatible with 2.7.1.
The code is in org.apache.dubbo.metadata.identifier.MetadataIdentifier
| I am working on the fix. | 2019-05-27 02:22:58+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=MetadataIdentifierTest -DfailIfNoTests=false -fa... | [] | ['org.apache.dubbo.metadata.identifier.MetadataIdentifierTest.testGetUniqueKey'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=MetadataIdentifierTest -DfailIfNoTests=false -... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["dubbo-metadata-report/dubbo-metadata-report-api/src/main/java/org/apache/dubbo/metadata/identifier/MetadataIdentifier.java->program->class_declaration:MetadataIdentifier->method_declaration:String_getUniqueKey"] |
apache/dubbo | 4,678 | apache__dubbo-4678 | ['4248'] | f2af6fdbf671fb8fa472f44f841f40e369f84857 | diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/MethodUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/MethodUtils.java
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/MethodUtils.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/MethodUtils.ja... | diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/MethodUtilsTest.java b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/MethodUtilsTest.java
--- a/dubbo-common/src/test/java/org/apache/dubbo/common/utils/MethodUtilsTest.java
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/utils/Me... | dubbo2.7.1-AbstractConfig.java-getMetaData set default depend on getmethod sequence
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this reposito... | add the code
if(parameter.excluded())
continue;
centos update the jdk version to oracle jdk java version "1.8.0_211" it is same to openjdk。
maybe different platform compile is different，methods sequence different.
it is ok run with dubbo-2.6.2 | 2019-07-27 04:20:27+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=AbstractReferenceConfigTest,MethodUtilsTest -Dfa... | [] | ['org.apache.dubbo.common.utils.MethodUtilsTest.testIsDeprecated', 'org.apache.dubbo.config.AbstractReferenceConfigTest.testGroup', 'org.apache.dubbo.config.AbstractReferenceConfigTest.testGeneric', 'org.apache.dubbo.config.AbstractReferenceConfigTest.testListener', 'org.apache.dubbo.config.AbstractReferenceConfigTest.... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=AbstractReferenceConfigTest,MethodUtilsTest -D... | Bug Fix | false | false | false | true | 6 | 1 | 7 | false | false | ["dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java->program->class_declaration:ReferenceConfig->method_declaration:init", "dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/AbstractReferenceConfig.java->program->class_declaration:AbstractReferenceConfig->method_... |
google/gson | 769 | google__gson-769 | ['768'] | 1f803bd37de5890f6da53f0b1a1b631eea4d1b8f | diff --git a/gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java b/gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java
--- a/gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java
+++ b/gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java
@@ -1... | diff --git a/gson/src/test/java/com/google/gson/DefaultDateTypeAdapterTest.java b/gson/src/test/java/com/google/gson/DefaultDateTypeAdapterTest.java
--- a/gson/src/test/java/com/google/gson/DefaultDateTypeAdapterTest.java
+++ b/gson/src/test/java/com/google/gson/DefaultDateTypeAdapterTest.java
@@ -130,6 +130,7 @@ publi... | ISO8601 is not fully implemented
Hi guys,
I'm working on a project where I have to parse `2016-01-11T11:06:14.000-02` to java.util.Date which is a valid date according to [RFC3339](https://www.ietf.org/rfc/rfc3339.txt) on page 12.
But I got an Exception trying to archive it
```
Caused by: com.google.gson.JsonSyntaxE... | Does using the `UtcDateTypeAdapter` work? https://github.com/google/gson/blob/master/extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
| 2016-01-11 17:37:29+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['com.google.gson.DefaultDateTypeAdapterTest.testFormattingInFr', 'com.google.gson.DefaultDateTypeAdapterTest.testDateDeserializationISO8601', 'com.google.gson.DefaultDateTypeAdapterTest.testInvalidDatePattern', 'com.google.gson.DefaultDateTypeAdapterTest.testFormatUsesDefaultTimezone', 'com.google.gson.DefaultDateType... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=DefaultDateTypeAdapterTest -DfailIfNoTests=false -fae surefire-repor... | Bug Fix | false | false | false | true | 1 | 1 | 2 | false | false | ["gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java->program->class_declaration:ISO8601Utils->method_declaration:Date_parse", "gson/src/main/java/com/google/gson/internal/bind/util/ISO8601Utils.java->program->class_declaration:ISO8601Utils"] |
apache/rocketmq | 6,651 | apache__rocketmq-6651 | ['6650'] | fad3dece7b88bc62c5beae1a492917bfd85d87ed | diff --git a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java b/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java
--- a/tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java
+++ b/tieredstore/src/main/java/org/apache/rocketmq/t... | diff --git a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredMessageStoreTest.java b/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredMessageStoreTest.java
--- a/tieredstore/src/test/java/org/apache/rocketmq/tieredstore/TieredMessageStoreTest.java
+++ b/tieredstore/src/test/java/org/apach... | Fix using the deprecated method `MessgaeStore#checkInDiskByConsumeOffset`
**Fix using the deprecated method `MessgaeStore#checkInDiskByConsumeOffset`**
close issue: https://github.com/apache/rocketmq/issues/5837
The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow ... | null | 2023-04-25 12:37:04+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | ['org.apache.rocketmq.tieredstore.TieredMessageStoreTest.testQueryMessage', 'org.apache.rocketmq.tieredstore.TieredMessageStoreTest.testShutdownAndDestroy', 'org.apache.rocketmq.tieredstore.TieredMessageStoreTest.testGetEarliestMessageTimeAsync'] | ['org.apache.rocketmq.tieredstore.TieredMessageStoreTest.testGetMessageAsync'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=TieredMessageStoreTest -DfailIfNoTests=false -fae surefire-report:re... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java->program->class_declaration:TieredMessageStore->method_declaration:getMessageAsync"] |
apache/dubbo | 5,708 | apache__dubbo-5708 | ['5707'] | c0d62ed7a83347fa469c2b2a7d75287a5feb799b | diff --git a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/SelectTelnetHandler.java b/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/SelectTelnetHandler.java
--- a/dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/SelectTelnetHandler.java
+++ b/dubbo-plugin/dubbo-qos/... | diff --git a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/InvokerTelnetHandlerTest.java b/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/InvokerTelnetHandlerTest.java
--- a/dubbo-plugin/dubbo-qos/src/test/java/org/apache/dubbo/qos/legacy/InvokerTelnetHandlerTest.java
+++ b/dubbo-pl... | SelectTelnetHandler will select error method，sometime will throw IndexOutOfBoundsException
- [X] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [X] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this... | null | 2020-02-04 09:36:45+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=InvokerTelnetHandlerTest -DfailIfNoTests=false -... | ['org.apache.dubbo.qos.legacy.InvokerTelnetHandlerTest.testInvokeDefaultService', 'org.apache.dubbo.qos.legacy.InvokerTelnetHandlerTest.testInvokeMultiJsonParamMethod', 'org.apache.dubbo.qos.legacy.InvokerTelnetHandlerTest.testInvokeByPassingEnumValue', 'org.apache.dubbo.qos.legacy.InvokerTelnetHandlerTest.testInvokeWi... | ['org.apache.dubbo.qos.legacy.InvokerTelnetHandlerTest.testInvokeOverriddenMethodBySelect'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=InvokerTelnetHandlerTest -DfailIfNoTests=false... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/legacy/SelectTelnetHandler.java->program->class_declaration:SelectTelnetHandler->method_declaration:String_telnet"] |
apache/rocketmq | 1,742 | apache__rocketmq-1742 | ['1741'] | c233f65a0c1207d1d4ec94121e0024084ee82c6a | diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java b/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
--- a/client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java
+++ b/clien... | diff --git a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java b/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
--- a/client/src/test/java/org/apache/rocketmq/client/impl/consumer/ProcessQueueTest.java
+++ b/client/src/test/java/org/apache/rocketmq/... | rename takeMessags to takeMessages
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
just rename function name, takeMessages is used internarlly, never influence user face
2. Provide any additional detail on your proposed use case for this feature.
2. Indicate the importance of this iss... | null | 2020-01-23 06:59:25+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.client.impl.consumer.ProcessQueueTest.testCachedMessageSize', 'org.apache.rocketmq.client.impl.consumer.ProcessQueueTest.testCachedMessageCount', 'org.apache.rocketmq.client.impl.consumer.ProcessQueueTest.testFillProcessQueueInfo'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=ProcessQueueTest -DfailIfNoTests=false -fae surefire-report:report -... | Refactoring | false | true | false | false | 3 | 0 | 3 | false | false | ["client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java->program->class_declaration:ProcessQueue->method_declaration:takeMessags", "client/src/main/java/org/apache/rocketmq/client/impl/consumer/ProcessQueue.java->program->class_declaration:ProcessQueue->method_declaration:takeMessages", "clien... |
apache/rocketmq | 7,544 | apache__rocketmq-7544 | ['7543'] | 00965d8c11833237d5c9cd925664a1c456493cee | diff --git a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java
--- a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java
+++ b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainAccessResource.java
@... | diff --git a/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java b/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java
new file mode 100644
--- /dev/null
+++ b/common/src/test/java/org/apache/rocketmq/common/KeyBuilderTest.java
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Fou... | [Enhancement] Pop retry topic v2
### Before Creating the Enhancement Request
- [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.
### Summary
目前在pop机制中使用的retry topic的格式是形如 "%RETRY%group_topic"，其中分隔符"_"是一个合法字符，可以被使用在topic或者group中，因此会导致两个问题。
1. pop retry topic重复... | null | 2023-11-07 07:12:10+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.common.KeyBuilderTest.isPopRetryTopicV2', 'org.apache.rocketmq.common.KeyBuilderTest.parseGroup', 'org.apache.rocketmq.common.KeyBuilderTest.buildPopRetryTopic', 'org.apache.rocketmq.common.KeyBuilderTest.testParseNormalTopic', 'org.apache.rocketmq.common.KeyBuilderTest.buildPopRetryTopicV1', 'org... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=KeyBuilderTest -DfailIfNoTests=false -fae surefire-report:report -Ds... | Feature | true | false | false | false | 0 | 0 | 0 | false | false | ["broker/src/main/java/org/apache/rocketmq/broker/processor/PopMessageProcessor.java->program->class_declaration:PopMessageProcessor->method_declaration:RemotingCommand_processRequest", "broker/src/main/java/org/apache/rocketmq/broker/metrics/ConsumerLagCalculator.java->program->class_declaration:ConsumerLagCalculator-... |
apolloconfig/apollo | 4,119 | apolloconfig__apollo-4119 | ['3557'] | b2c101aaecd34339afcc4844311f37280d03d48e | diff --git a/apollo-adminservice/src/main/resources/application-zookeeper-discovery.properties b/apollo-adminservice/src/main/resources/application-zookeeper-discovery.properties
new file mode 100644
--- /dev/null
+++ b/apollo-adminservice/src/main/resources/application-zookeeper-discovery.properties
@@ -0,0 +1,22 @@
+... | diff --git a/apollo-adminservice/src/test/resources/application.properties b/apollo-adminservice/src/test/resources/application.properties
--- a/apollo-adminservice/src/test/resources/application.properties
+++ b/apollo-adminservice/src/test/resources/application.properties
@@ -19,4 +19,5 @@ spring.jpa.properties.hiber... | Support register to Zookeeper
**Is your feature request related to a problem? Please describe.**
One maybe need to register apollo to [zookeeper](https://zookeeper.apache.org/)
**Describe the solution you'd like**
Implement it Like in pull request
#3055
#3447
| apollo 默认内置 Eureka 作为注册中心用来管理 apollo-configservice 和 apollo-adminservice 的服务实例列表。不过在实际使用中，有些公司为了统一管理，所以希望 apollo-configservice 和 apollo-adminservice 注册到公司内部已有的注册中心，比如 consul，nacos，zookeeper，kubernetes 等，目前 apollo 已经支持和 eureka, consul, nacos, kubernetes 等集成，所以需要增加对 zookeeper 的支持。 | 2021-11-27 07:41:05+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['com.ctrip.framework.apollo.metaservice.service.ZookeeperDiscoveryServiceTest.testGetServiceInstancesWithEmptyInstances', 'com.ctrip.framework.apollo.metaservice.service.ConsulDiscoveryServiceTest.testGetServiceInstancesWithNullInstances', 'com.ctrip.framework.apollo.metaservice.service.ZookeeperDiscoveryServiceTest.t... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=application.properties,ConsulDiscoveryServiceTest,ZookeeperDiscovery... | Feature | false | false | true | false | 0 | 2 | 2 | false | false | ["apollo-configservice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/HomePageController.java->program->class_declaration:HomePageController", "apollo-configservice/src/main/java/com/ctrip/framework/apollo/metaservice/service/DefaultDiscoveryService.java->program->class_declaration:DefaultDiscoveryServ... |
apache/rocketmq | 5,037 | apache__rocketmq-5037 | ['5036'] | f8bf7bd38b11ca025c5795a8e4a03bd577f47273 | diff --git a/common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java b/common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java
--- a/common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java
+++ b/common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCod... | diff --git a/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java b/controller/src/test/java/org/apache/rocketmq/controller/impl/controller/impl/manager/ReplicasInfoManagerTest.java
--- a/controller/src/test/java/org/apache/rocketmq/controller/impl/controller... | Optimize controller module Response code
In Controller module process Request, if handle failure most return **CONTROLLER_INVALID_REQUEST** code. Optimize return code, Make its semantics clearer.
ReplicasInfoManager#alterSyncStateSet, as following picture:
![image](https://user-images.githubusercontent.com/15797831/... | null | 2022-09-09 07:22:37+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.controller.impl.controller.impl.manager.ReplicasInfoManagerTest.testElectMasterOldMasterStillAlive', 'org.apache.rocketmq.controller.impl.controller.impl.manager.ReplicasInfoManagerTest.testAllReplicasShutdownAndRestart', 'org.apache.rocketmq.controller.impl.controller.impl.manager.ReplicasInfoMan... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=ReplicasInfoManagerTest -DfailIfNoTests=false -fae surefire-report:r... | Refactoring | false | false | false | true | 3 | 1 | 4 | false | false | ["common/src/main/java/org/apache/rocketmq/common/protocol/ResponseCode.java->program->class_declaration:ResponseCode", "controller/src/main/java/org/apache/rocketmq/controller/impl/manager/ReplicasInfoManager.java->program->class_declaration:ReplicasInfoManager->method_declaration:registerBroker", "controller/src/main... |
apache/rocketmq | 6,401 | apache__rocketmq-6401 | ['6402'] | 68362151a272cce4e318238138b5e5de5344220f | diff --git a/broker/src/main/java/org/apache/rocketmq/broker/processor/EndTransactionProcessor.java b/broker/src/main/java/org/apache/rocketmq/broker/processor/EndTransactionProcessor.java
--- a/broker/src/main/java/org/apache/rocketmq/broker/processor/EndTransactionProcessor.java
+++ b/broker/src/main/java/org/apache/... | diff --git a/broker/src/test/java/org/apache/rocketmq/broker/processor/EndTransactionProcessorTest.java b/broker/src/test/java/org/apache/rocketmq/broker/processor/EndTransactionProcessorTest.java
--- a/broker/src/test/java/org/apache/rocketmq/broker/processor/EndTransactionProcessorTest.java
+++ b/broker/src/test/java... | opt transaction message check
The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a n... | null | 2023-03-20 03:48:48+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.broker.processor.EndTransactionProcessorTest.testProcessRequest_RejectCommitMessage', 'org.apache.rocketmq.broker.transaction.queue.TransactionalMessageUtilTest.testBuildTransactionalMessageFromHalfMessage', 'org.apache.rocketmq.broker.processor.EndTransactionProcessorTest.testProcessRequest_Check... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=TransactionalMessageUtilTest,EndTransactionProcessorTest -DfailIfNoT... | Bug Fix | false | false | false | true | 3 | 4 | 7 | false | false | ["broker/src/main/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageUtil.java->program->class_declaration:TransactionalMessageUtil->method_declaration:getImmunityTime", "common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java->program->class_declaration:BrokerConfig", "remoting/src/main/ja... |
apache/dubbo | 4,026 | apache__dubbo-4026 | ['4007'] | e69086400c188154bd1ac9592df2f7a077d08769 | diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java
@@ -3... | diff --git a/dubbo-common/src/test/java/org/apache/dubbo/common/model/User.java b/dubbo-common/src/test/java/org/apache/dubbo/common/model/User.java
new file mode 100644
--- /dev/null
+++ b/dubbo-common/src/test/java/org/apache/dubbo/common/model/User.java
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Founda... | telnet can't work when parameter has no nullary constructor and some fields is primitive
### Environment
* Dubbo version: 2.6.0
* Operating System version: macOS 10.14.3
* Java version: 1.8.0_201
### Steps to reproduce this issue
1. create a class has no nullary constructor and some fields is primitive
```j... | should init primitive before new instance
com.alibaba.dubbo.common.utils.PojoUtils#newInstance:L527
pseudo code like this
```java
Class<?>[] parameterTypes = constructor.getParameterTypes();
Object[] parameters = new Object[parameterTypes.length];
for (int i = 0; i < parameterTypes.length; i++) {
if (paramet... | 2019-05-10 17:28:53+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw clean install -am -Dtest=User,PojoUtilsTest -DfailIfNoTests=false -fae -D... | ['org.apache.dubbo.common.utils.PojoUtilsTest.testGeneralizePersons', 'org.apache.dubbo.common.utils.PojoUtilsTest.test_PojoInList', 'org.apache.dubbo.common.utils.PojoUtilsTest.test_simpleCollection', 'org.apache.dubbo.common.utils.PojoUtilsTest.test_PrimitiveArray', 'org.apache.dubbo.common.utils.PojoUtilsTest.testPo... | ['org.apache.dubbo.common.utils.PojoUtilsTest.test_has_no_nullary_constructor_pojo'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && if [ -e mvnw ]; then ./mvnw test -am -Dtest=User,PojoUtilsTest -DfailIfNoTests=false -fae ... | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java->program->class_declaration:PojoUtils->method_declaration:Object_getDefaultValue", "dubbo-common/src/main/java/org/apache/dubbo/common/utils/PojoUtils.java->program->class_declaration:PojoUtils->method_declaration:Object_newInstance", "dubbo-comm... |
apache/rocketmq | 3,927 | apache__rocketmq-3927 | ['3922'] | 5ae4a106bdd83848ae12e870e8f0f587bd107500 | diff --git a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java
--- a/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java
+++ b/acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionMa... | diff --git a/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessControlFlowTest.java b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessControlFlowTest.java
new file mode 100644
--- /dev/null
+++ b/acl/src/test/java/org/apache/rocketmq/acl/plain/PlainAccessControlFlowTest.java
@@ -0,0 +1,396 @@
+/*
+ ... | mqadmin updateGlobalWhiteAddr failed in 4.9.3
**BUG REPORT**
1. Please describe the issue you observed:
新版本 4.9.3 中提供了ACL多配置文件功能
默认配置文件从原来的 /conf/plain_acl.yml 改为 /conf/acl/plain_acl.yml
但是 mqadmin 依然只能修改 /conf/plain_acl.yml
初始部署时，如果手动创建 /conf/plain_acl.yml ，写入全局IP白名单，会导致 mqadmin 无法修改 ACL 配置，报错如下：
... | @caigy @sunxi92 Would you like to resolve this issue?
> @caigy @sunxi92 Would you like to resolve this issue?
Let me look at the problem first
另外发现，/conf/plain_acl.yml 和 /conf/acl/plain_acl.yml 共存的情况下：
全局IP白名单保存在 /conf/acl/plain_acl.yml
account保存在 /conf/plain_acl.yml
此时通过 CLI 添加的2个或者2个以上 account 规则后，虽然可以通过 mqad... | 2022-03-03 14:04:02+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.acl.plain.PlainAccessControlFlowTest.testOnlyAclFolderCase'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=plain_acl.yml,PlainAccessControlFlowTest -DfailIfNoTests=false -fae ... | Bug Fix | false | false | false | true | 8 | 1 | 9 | false | false | ["acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java->program->class_declaration:PlainPermissionManager->method_declaration:load", "acl/src/main/java/org/apache/rocketmq/acl/plain/PlainPermissionManager.java->program->class_declaration:PlainPermissionManager->method_declaration:updateAccessConf... |
apache/rocketmq | 4,763 | apache__rocketmq-4763 | ['4762'] | 87918f13a417b704d809172aeea8e1def1282f7b | diff --git a/proxy/src/main/java/org/apache/rocketmq/proxy/config/MetricCollectorMode.java b/proxy/src/main/java/org/apache/rocketmq/proxy/config/MetricCollectorMode.java
--- a/proxy/src/main/java/org/apache/rocketmq/proxy/config/MetricCollectorMode.java
+++ b/proxy/src/main/java/org/apache/rocketmq/proxy/config/Metric... | diff --git a/proxy/src/test/java/org/apache/rocketmq/proxy/config/MetricCollectorModeTest.java b/proxy/src/test/java/org/apache/rocketmq/proxy/config/MetricCollectorModeTest.java
--- a/proxy/src/test/java/org/apache/rocketmq/proxy/config/MetricCollectorModeTest.java
+++ b/proxy/src/test/java/org/apache/rocketmq/proxy/c... | Use string as the configuration parameter type of metrics collector mode
Current parameter type of metrics is `int` - `0/1/2` , which may confuse the developer.
or we could use the string type - `on/off/proxy`, which may make it much clearer.
| null | 2022-08-02 06:11:07+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
RUN export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && sed -i 's/^.*\*\*\/IT\*\.java.*$/<exclude>**\/IT*.java<\/exclude><exclude>%regex[.*MixCommitlogTest.*]<\/exclude>/' pom.xml && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corret... | [] | ['org.apache.rocketmq.proxy.config.MetricCollectorModeTest.testGetEnumByOrdinal'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-1.8.0-amazon-corretto.x86_64/jre/bin/java && mvn verify -am -Dtest=MetricCollectorModeTest -DfailIfNoTests=false -fae surefire-report:r... | Refactoring | false | false | false | true | 8 | 2 | 10 | false | false | ["proxy/src/main/java/org/apache/rocketmq/proxy/config/MetricCollectorMode.java->program->constructor_declaration:MetricCollectorMode", "proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java->program->class_declaration:ProxyConfig->method_declaration:getMetricCollectorMode", "proxy/src/main/java/org/apa... |
trinodb/trino | 5,945 | trinodb__trino-5945 | ['4543'] | 126e5e1354f334a7a2b0ae83a72fa4193b47c178 | diff --git a/presto-main/src/main/java/io/prestosql/execution/CreateMaterializedViewTask.java b/presto-main/src/main/java/io/prestosql/execution/CreateMaterializedViewTask.java
index ceec57660d75..f550796e7d1a 100644
--- a/presto-main/src/main/java/io/prestosql/execution/CreateMaterializedViewTask.java
+++ b/presto-mai... | diff --git a/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java b/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java
index 05700ae80442..6cc0a33abe33 100644
--- a/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java
+++ b/presto-main/src/... | GroupProvider groups are not available for View Access Control
View access control checks permissions of the view creator, since a View is equivalent to a Grant. If FileBasedAccessControl and a GroupProvider are being used this leads to surprising results, because GroupProviderManager.getGroups is never called for the ... | null | 2020-11-13 02:04:48+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.sql.analyzer.TestAnalyzer.testGroupingTooManyArguments', 'io.prestosql.sql.analyzer.TestAnalyzer.testNotNullInJoinClause', 'io.prestosql.sql.analyzer.TestAnalyzer.testNonAggregationDistinct', 'io.prestosql.sql.analyzer.TestAnalyzer.testInvalidAttribute', 'io.prestosql.sql.analyzer.TestAnalyzer.testInVali... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 31 | 17 | 48 | false | false | ["presto-main/src/main/java/io/prestosql/execution/CreateMaterializedViewTask.java->program->class_declaration:CreateMaterializedViewTask->method_declaration:execute", "presto-main/src/main/java/io/prestosql/execution/CreateViewTask.java->program->class_declaration:CreateViewTask->constructor_declaration:CreateViewTask... |
trinodb/trino | 2,944 | trinodb__trino-2944 | ['2908'] | f3744f29bd8b92de83d792903f99ca80a3622070 | diff --git a/presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java b/presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java
index 4c0a7faa79ad..cb77ebfc1a80 100644
--- a/presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java
+++ ... | diff --git a/presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java b/presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java
index 192dd4827cb0..279e5a6363f8 100644
--- a/presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.java
+++ b/presto-main/src/test/java/io/prestosql/server/ui/TestWebUi.ja... | New WebUI Authentication Manager Breaks Forwarded HTTPS
We use a load balancer in front of Presto to handle HTTPS. The load balancer forwards to Presto on port 8080. We enable `http-server.authentication.allow-forwarded-https` to support authentication in this scenario.
Running a snapshot of master, I am not able ... | Configuring the load balancer to listen on a port besides 443 works around the issue. `https://presto.domain.com:4433` is accessible.
> Browsing to `https://presto.domain.com` delivers a 303 status code, redirecting to `https://presto.domain.com:80/ui`.
Is your load balancer sending `X-Forwarded-For`, `X-Forwarded-... | 2020-02-25 23:54:18+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.server.ui.TestWebUi.testNoPasswordAuthenticator', 'io.prestosql.server.ui.TestWebUi.testFailedLogin', 'io.prestosql.server.ui.TestWebUi.testLogIn', 'io.prestosql.server.ui.TestWebUi.testWorkerResource'] | ['io.prestosql.server.ui.TestWebUi.testRootRedirect', 'io.prestosql.server.ui.TestWebUi.testDisabled', 'io.prestosql.server.ui.TestWebUi.testLoggedOut'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java->program->class_declaration:FormWebUiAuthenticationManager->method_declaration:String_getRedirectLocation", "presto-main/src/main/java/io/prestosql/server/ui/FormWebUiAuthenticationManager.java->program->class_declaration:FormWebUiAu... |
trinodb/trino | 657 | trinodb__trino-657 | ['655'] | 694a68c1269cc92d4f26cd3ced795b4bcb75c6bc | diff --git a/presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraColumnHandle.java b/presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraColumnHandle.java
index df4c7e56b033..61e69bdf0d92 100644
--- a/presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraColumnHandle.... | diff --git a/presto-cassandra/src/test/java/io/prestosql/plugin/cassandra/TestCassandraColumnHandle.java b/presto-cassandra/src/test/java/io/prestosql/plugin/cassandra/TestCassandraColumnHandle.java
index 31fb7aaa7fe5..0d04e89a5fa7 100644
--- a/presto-cassandra/src/test/java/io/prestosql/plugin/cassandra/TestCassandraC... | Support nested collection type in Cassandra connector
Current Cassandra connector throws NPE if the column has nested collection type.
```sql
CREATE TABLE test_nested_collection (
c1 int PRIMARY KEY,
c2 frozen<set<frozen<set<int>>>>
)
```
| null | 2019-04-22 14:09:19+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.cassandra.TestCassandraIntegrationSmokeTest.testClusteringKeyOnlyPushdown', 'io.prestosql.plugin.cassandra.TestCassandraIntegrationSmokeTest.testDuplicatedRowCreateTable', 'io.prestosql.plugin.cassandra.TestCassandraIntegrationSmokeTest.testInListPredicate', 'io.prestosql.plugin.cassandra.TestCass... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 21 | 7 | 28 | false | false | ["presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraColumnHandle.java->program->class_declaration:CassandraColumnHandle->method_declaration:getTypeArguments", "presto-cassandra/src/main/java/io/prestosql/plugin/cassandra/CassandraRecordCursor.java->program->class_declaration:CassandraRecordCursor->m... |
trinodb/trino | 1,804 | trinodb__trino-1804 | ['1674'] | b8d903e8540cb105cbcfb354ea45e46380ef267d | diff --git a/presto-accumulo/pom.xml b/presto-accumulo/pom.xml
index 7ccf2d247428..2ab84dfc2e6b 100644
--- a/presto-accumulo/pom.xml
+++ b/presto-accumulo/pom.xml
@@ -192,6 +192,11 @@
<artifactId>concurrent</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.airlift</groupI... | diff --git a/presto-main/src/test/java/io/prestosql/execution/MockManagedQueryExecution.java b/presto-main/src/test/java/io/prestosql/execution/MockManagedQueryExecution.java
index 2b1b01b27673..e5674511d8f4 100644
--- a/presto-main/src/test/java/io/prestosql/execution/MockManagedQueryExecution.java
+++ b/presto-main/s... | Units (eg @MinDuration) not validated in plugin's Config class
`@MinDuration` works e.g. in `FeaturesConfig`,
but does not work e.g. in `CachingHiveMetastoreConfig`
| Proposed solution (based on my guess as to what's the root cause):
1. split airlift units into `units` and `units-validation`
2. do not include `units-validation` in SPI classloader
Alternatively we could add validation annotations to SPI, but I would prefer not to.
The root cause is that `@MinDuration` and othe... | 2019-10-19 01:21:27+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.execution.resourcegroups.TestResourceGroups.testCpuUsageUpdateAtQueryCompletion', 'io.prestosql.execution.resourcegroups.TestResourceGroups.testGetResourceGroupStateInfo', 'io.prestosql.execution.resourcegroups.TestResourceGroups.testWeightedScheduling', 'io.prestosql.execution.resourcegroups.TestResourc... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 28 | 11 | 39 | false | false | ["presto-main/src/main/java/io/prestosql/Session.java->program->class_declaration:Session->class_declaration:ResourceEstimateBuilder->method_declaration:ResourceEstimates_build", "presto-main/src/main/java/io/prestosql/execution/resourcegroups/InternalResourceGroup.java->program->class_declaration:InternalResourceGroup... |
trinodb/trino | 741 | trinodb__trino-741 | ['625'] | 0a0689eeb6248ebd7d55a019fa0a393bff02e209 | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java
index 226588ed24ea..3184ed9808c5 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetasto... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/TestPrestoS3FileSystem.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/TestPrestoS3FileSystem.java
index b08a02be41ce..2dbd95112118 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/TestPrestoS3FileSystem.java
+++ b/presto-... | PrestoS3ClientFactory should use the AWS Java SDK default credential provider
The Glue Hive Metastore provider uses the default [AWSGlueAsyncClientBuilder](https://github.com/prestosql/presto/blob/d8131337f69a58852ac2596b8b5dda6a48efd4c1/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastor... | This seems reasonable. We could add a new config, `hive.s3.use-default-credentials`, that when true, would return `null` as the credential provider rather than throwing an exception when no other credentials are available. This should be done for both `PrestoS3ClientFactory` and `PrestoS3FileSystem`. This config could ... | 2019-05-10 17:26:14+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testPathStyleAccess', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testReadNotFound', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testUnrecoverableS3ExceptionMessage', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testKMSEncryptionMaterialsProvid... | ['io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testDefaultCredentials'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 4 | 1 | 5 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java->program->class_declaration:GlueHiveMetastore->method_declaration:AWSGlueAsync_createAsyncGlueClient", "presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3ClientFactory.java->program->class_declaration:PrestoS3ClientFa... |
trinodb/trino | 1,872 | trinodb__trino-1872 | ['574'] | 14a301a6f79d8ad6eebf5a59856d7e7739624b46 | diff --git a/presto-main/src/main/java/io/prestosql/SystemSessionProperties.java b/presto-main/src/main/java/io/prestosql/SystemSessionProperties.java
index d415a5fe15cb..69a606566c4b 100644
--- a/presto-main/src/main/java/io/prestosql/SystemSessionProperties.java
+++ b/presto-main/src/main/java/io/prestosql/SystemSess... | diff --git a/presto-main/src/test/java/io/prestosql/sql/analyzer/TestFeaturesConfig.java b/presto-main/src/test/java/io/prestosql/sql/analyzer/TestFeaturesConfig.java
index 2a4dbacfbb4b..dd8dd7f4d074 100644
--- a/presto-main/src/test/java/io/prestosql/sql/analyzer/TestFeaturesConfig.java
+++ b/presto-main/src/test/java... | Partial Aggregation not being pushed through UNION ALL
presto version:0.201
the difference between table and view ,there is a “Aggregate(PARTIAL)” in table query
the sql to create view :
```sql
CREATE VIEW hive.db_benchmarksd0121.event_vd_test AS
SELECT * FROM hive.db_benchmarksd0121.event
UNION ALL
SELECT *... | I’m planning to work on this. Can anyone assign it to me please ?
hi,i found some clue, PushPartialAggregationThroughExchange's PATTERN
private static final Pattern<AggregationNode> PATTERN = aggregation()
.with(source().matching(exchange().capturedAs(EXCHANGE_NODE)));
only work with this .
Aggregat... | 2019-10-26 10:09:49+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testNonSpillableBroadcastJoinAboveTableScan', 'io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testForcePartitioningMarkDistinctInput', 'io.prestosql.sql.analyzer.TestFeaturesConfig.testExplicitPropertyMappings', 'io.prestosql.sql.analyzer.Test... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 10 | 4 | 14 | false | false | ["presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddExchanges.java->program->class_declaration:AddExchanges->class_declaration:Rewriter->method_declaration:PlanWithProperties_visitAggregation", "presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddExchanges.java->program->class_declarat... |
trinodb/trino | 2,707 | trinodb__trino-2707 | ['1983'] | 2dd60c71da052d299ead42f4e3f1bb7ce9664086 | diff --git a/presto-docs/src/main/sphinx/develop/functions.rst b/presto-docs/src/main/sphinx/develop/functions.rst
index a69c6d24671b..a77bde48fcfa 100644
--- a/presto-docs/src/main/sphinx/develop/functions.rst
+++ b/presto-docs/src/main/sphinx/develop/functions.rst
@@ -157,7 +157,7 @@ The ``lowercaser`` function takes... | diff --git a/presto-main/src/main/java/io/prestosql/operator/scalar/Greatest.java b/presto-main/src/main/java/io/prestosql/operator/scalar/Greatest.java
index 39d4e393d8bf..8639f7736afb 100644
--- a/presto-main/src/main/java/io/prestosql/operator/scalar/Greatest.java
+++ b/presto-main/src/main/java/io/prestosql/operato... | Fix format for @Description value
Currently, the format of function description is varied as below (The first character uppercase/lowercase and the following period)
- `word_stem`: returns the stem of a word in the given language
- `zip`: Merges the given arrays, element-wise, into a single array of rows.
| Let's settle on sentence case (uppercase first letter). | 2020-02-02 01:12:09+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.operator.scalar.TestStringFunctions.testCharLength', 'io.prestosql.operator.scalar.TestStringFunctions.testSubstring', 'io.prestosql.operator.scalar.TestStringFunctions.testCharSubstring', 'io.prestosql.operator.scalar.TestStringFunctions.testNormalize', 'io.prestosql.operator.scalar.TestStringFunctions.... | ['io.prestosql.sql.query.TestShowQueries.testShowFunctionsLikeWithEscape', 'io.prestosql.sql.query.TestShowQueries.testShowFunctionLike'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Refactoring | false | false | false | true | 238 | 26 | 264 | false | false | ["presto-main/src/main/java/io/prestosql/operator/scalar/VarbinaryFunctions.java->program->class_declaration:VarbinaryFunctions->method_declaration:Slice_sha1", "presto-main/src/main/java/io/prestosql/operator/scalar/ArrayFilterFunction.java->program->class_declaration:ArrayFilterFunction", "presto-main/src/main/java/i... |
trinodb/trino | 1,174 | trinodb__trino-1174 | ['338'] | e78fafdbbc94e5094cb2c3f61b4b39533224bfe7 | diff --git a/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java b/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java
index cce57011d5da..e0204632dc75 100644
--- a/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java
+++ b/presto-base-jdbc/src/main... | diff --git a/presto-base-jdbc/src/test/java/io/prestosql/plugin/jdbc/TestJdbcOutputTableHandle.java b/presto-base-jdbc/src/test/java/io/prestosql/plugin/jdbc/TestJdbcOutputTableHandle.java
index 3bed802aca47..2e65ce39bbfc 100644
--- a/presto-base-jdbc/src/test/java/io/prestosql/plugin/jdbc/TestJdbcOutputTableHandle.jav... | When writing to existing table with JDBC-based connector, temporary table should match destination table's column types
See TODO in the code
https://github.com/prestosql/presto/blob/d7032e84ba2e36aa7a3ebb3962b6889d8a47d3c8/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L325-L326
| null | 2019-07-24 23:10:49+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.jdbc.TestJdbcOutputTableHandle.testJsonRoundTrip'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 22 | 9 | 31 | false | false | ["presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java->program->class_declaration:BaseJdbcClient", "presto-phoenix/src/main/java/io/prestosql/plugin/phoenix/PhoenixMetadata.java->program->class_declaration:PhoenixMetadata->method_declaration:JdbcOutputTableHandle_createTable", "presto-base-jdbc/... |
trinodb/trino | 117 | trinodb__trino-117 | ['56'] | 06a7dc6b2d89c283ebf04cc54396167ae8ad22cb | diff --git a/presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java b/presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java
index d93013551d89..f6b7b408b89b 100644
--- a/presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java
+++ b/presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java
@@ -98,6 ... | diff --git a/presto-cli/src/test/java/io/prestosql/cli/TestClientOptions.java b/presto-cli/src/test/java/io/prestosql/cli/TestClientOptions.java
index 11a66471cde2..ff0bc63d8e5e 100644
--- a/presto-cli/src/test/java/io/prestosql/cli/TestClientOptions.java
+++ b/presto-cli/src/test/java/io/prestosql/cli/TestClientOption... | Add CLI option --trace-token to set the trace token
This should be easy as trace token is already in `ClientSession`.
| null | 2019-01-31 07:25:17+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.cli.TestClientOptions.testServerHostOnly', 'io.prestosql.cli.TestClientOptions.testSessionProperties', 'io.prestosql.cli.TestClientOptions.testEmptyPropertyName', 'io.prestosql.cli.TestClientOptions.testServerHttpsUri', 'io.prestosql.cli.TestClientOptions.testServerHttpUri', 'io.prestosql.cli.TestClientO... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 1 | 1 | 2 | false | false | ["presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java->program->class_declaration:ClientOptions", "presto-cli/src/main/java/io/prestosql/cli/ClientOptions.java->program->class_declaration:ClientOptions->method_declaration:ClientSession_toClientSession"] |
trinodb/trino | 767 | trinodb__trino-767 | ['766'] | 0a92cffa9c49347a6f4fb3668e27945d75e5efe3 | diff --git a/presto-main/src/main/java/io/prestosql/operator/ChannelSet.java b/presto-main/src/main/java/io/prestosql/operator/ChannelSet.java
index 734fa02634a1..872796811946 100644
--- a/presto-main/src/main/java/io/prestosql/operator/ChannelSet.java
+++ b/presto-main/src/main/java/io/prestosql/operator/ChannelSet.ja... | diff --git a/presto-main/src/test/java/io/prestosql/operator/TestHashSemiJoinOperator.java b/presto-main/src/test/java/io/prestosql/operator/TestHashSemiJoinOperator.java
index 11caf7abaf50..88ecb986b344 100644
--- a/presto-main/src/test/java/io/prestosql/operator/TestHashSemiJoinOperator.java
+++ b/presto-main/src/tes... | Use precomputed hash in HashSemiJoinOperator for probe
SemiJoin does not make use of precomputed hash on probe side when it is available. By default, `optimizer.optimize-hash-generation` is set to true so all SOURCE stages will output precomputed hash too. Ignoring it causes HashSemiJoinOperator to do duplicate computa... | null | 2019-05-14 05:02:42+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.operator.TestHashSemiJoinOperator.testSemiJoin', 'io.prestosql.operator.TestHashSemiJoinOperator.testProbeAndBuildNulls', 'io.prestosql.operator.TestHashSemiJoinOperator.testMemoryLimit', 'io.prestosql.operator.TestHashSemiJoinOperator.testSemiJoinMemoryReservationYield', 'io.prestosql.operator.TestHashS... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Refactoring | false | false | false | true | 7 | 6 | 13 | false | false | ["presto-main/src/main/java/io/prestosql/operator/HashSemiJoinOperator.java->program->class_declaration:HashSemiJoinOperator->class_declaration:HashSemiJoinOperatorFactory->constructor_declaration:HashSemiJoinOperatorFactory", "presto-main/src/main/java/io/prestosql/operator/ChannelSet.java->program->class_declaration:... |
trinodb/trino | 5,507 | trinodb__trino-5507 | ['1777'] | 075985b386daa6ae5c44328a4b6f20ce8684413a | diff --git a/presto-jdbc/pom.xml b/presto-jdbc/pom.xml
index 44cc256c22a2..03b42bd2a2f1 100644
--- a/presto-jdbc/pom.xml
+++ b/presto-jdbc/pom.xml
@@ -112,6 +112,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>io.prestosql</groupId>
+ <artifactId>pr... | diff --git a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcPreparedStatement.java b/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcPreparedStatement.java
index 65348988063f..0abfccc0375c 100644
--- a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcPreparedStatement.java
+++ b/presto-jdbc/src/test/java/io... | Support batching in JDBC PreparedStatement (INSERT)
The idea is here is to support batch JDBC `INSERT` queries which is very common use case.
User with JDBC tries to execute:
```
INSERT INTO x VALUES(1, .);
INSERT INTO x VALUES(2, ...);
INSERT INTO x VALUES(3, ...);
```
Using typicall approach with JDBC is u... | Implementing `addBatch()` and `executeBatch()` would be great. | 2020-10-10 15:33:45+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.jdbc.TestJdbcPreparedStatement.testExecuteQuery', 'io.prestosql.jdbc.TestJdbcPreparedStatement.testConvertInteger', 'io.prestosql.jdbc.TestJdbcPreparedStatement.testDeallocate', 'io.prestosql.jdbc.TestJdbcPreparedStatement.testConvertReal', 'io.prestosql.jdbc.TestPrestoDatabaseMetaData.testGetColumnsMeta... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 12 | 1 | 13 | false | false | ["presto-jdbc/src/main/java/io/prestosql/jdbc/PrestoPreparedStatement.java->program->class_declaration:PrestoPreparedStatement->method_declaration:ResultSet_executeQuery", "presto-jdbc/src/main/java/io/prestosql/jdbc/PrestoPreparedStatement.java->program->class_declaration:PrestoPreparedStatement->method_declaration:to... |
trinodb/trino | 4,393 | trinodb__trino-4393 | ['4378'] | 50b0646ba869ff59568daed9dae5f3dd57933671 | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java
index 5e770f27a523..99d8f1bf7a69 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java
+++ b/presto-... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java
index db31af897bdb..628460e62ed4 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java
+... | Hive connector silently ignores extra buckets
`BackgroundHiveSplitLoader.getBucketedSplits()` should verify that every bucket number is less than `partitionBucketNumber`. For example, create a table with a bucket count of `4` and then create these files:
```
0000_0
0001_0
0003_0
0004_0
0009_0
```
The files for ... | So basically we should catch this case - the highest bucket number that detected from data file should be less than `(table bucket number)` and then fail the query? But would it impact the data correctness in current implementation as anyway we skip those 2 invalid buckets? | 2020-07-09 01:16:53+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.TestBackgroundHiveSplitLoader.testNoHangIfPartitionIsOffline', 'io.prestosql.plugin.hive.TestBackgroundHiveSplitLoader.testPathFilterOneBucketMatchPartitionedTable', 'io.prestosql.plugin.hive.TestBackgroundHiveSplitLoader.testPathFilterBucketedPartitionedTable', 'io.prestosql.plugin.hive.Test... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 2 | 1 | 3 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java->program->class_declaration:BackgroundHiveSplitLoader", "presto-hive/src/main/java/io/prestosql/plugin/hive/BackgroundHiveSplitLoader.java->program->class_declaration:BackgroundHiveSplitLoader->method_declaration:getBucketedSplits", "pr... |
trinodb/trino | 2,366 | trinodb__trino-2366 | ['2356'] | ced0253574b406947672f1b2e6961a6b846a0c11 | diff --git a/presto-password-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java b/presto-password-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java
index e0dbd1c9d2dc..e1d3c98cd282 100644
--- a/presto-password-authenticators/src/main/java/io/prestos... | diff --git a/presto-password-authenticators/src/test/java/io/prestosql/plugin/password/ldap/TestLdapAuthenticator.java b/presto-password-authenticators/src/test/java/io/prestosql/plugin/password/ldap/TestLdapAuthenticator.java
new file mode 100644
index 000000000000..3ee094f33b88
--- /dev/null
+++ b/presto-password-aut... | LDAP injection attacks are possible through user field
LDAP password authenticator doesn't seem to escape special LDAP characters, which makes it possible to change the logic of LDAP searches and binds.
See [Testing for LDAP Injection](https://www.owasp.org/index.php/Testing_for_LDAP_Injection_(OTG-INPVAL-006)) or [... | null | 2019-12-30 14:27:01+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.password.ldap.TestLdapAuthenticator.testContainsSpecialCharacters'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Security | false | false | false | true | 3 | 1 | 4 | false | false | ["presto-password-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java->program->class_declaration:LdapAuthenticator", "presto-password-authenticators/src/main/java/io/prestosql/plugin/password/ldap/LdapAuthenticator.java->program->class_declaration:LdapAuthenticator->method_declaration... |
trinodb/trino | 4,129 | trinodb__trino-4129 | ['3827'] | b2c82193ce107856cb6554e1bfbf9483344c7bb6 | diff --git a/presto-main/src/main/java/io/prestosql/dispatcher/DispatchManager.java b/presto-main/src/main/java/io/prestosql/dispatcher/DispatchManager.java
index 61ce2b743b0c..c25eb6c3b215 100644
--- a/presto-main/src/main/java/io/prestosql/dispatcher/DispatchManager.java
+++ b/presto-main/src/main/java/io/prestosql/d... | diff --git a/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java b/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java
index 4dd7ca349955..7b7fd7c94cb2 100644
--- a/presto-main/src/main/java/io/prestosql/server/testing/TestingPrestoServer.java
+++ b/presto-main/src/... | WebUI and JMX don't agree on number of queued queries
I have a cluster with PrestoSQL 333 running and the WebUI and JMX metrics are showing different values for queued queries.
## Current Status According to WebUI
 while it is in ... | 2020-06-22 01:45:13+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.execution.TestExecutionJmxMetrics.testQueryStats'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 12 | 3 | 15 | false | false | ["presto-main/src/main/java/io/prestosql/execution/QueryManagerStats.java->program->class_declaration:QueryManagerStats->method_declaration:queryStarted", "presto-main/src/main/java/io/prestosql/dispatcher/DispatchManager.java->program->class_declaration:DispatchManager->method_declaration:getQueuedQueries", "presto-ma... |
trinodb/trino | 3,208 | trinodb__trino-3208 | ['3195'] | b66262b87ded75cf00a9628956339b8e34f9b934 | diff --git a/presto-memory/src/main/java/io/prestosql/plugin/memory/MemoryMetadata.java b/presto-memory/src/main/java/io/prestosql/plugin/memory/MemoryMetadata.java
index fc8bf1517c1a..9257aa62485d 100644
--- a/presto-memory/src/main/java/io/prestosql/plugin/memory/MemoryMetadata.java
+++ b/presto-memory/src/main/java/... | diff --git a/presto-memory/src/test/java/io/prestosql/plugin/memory/TestMemoryMetadata.java b/presto-memory/src/test/java/io/prestosql/plugin/memory/TestMemoryMetadata.java
index 50f1f16062a4..e5fbff8e3d02 100644
--- a/presto-memory/src/test/java/io/prestosql/plugin/memory/TestMemoryMetadata.java
+++ b/presto-memory/sr... | Presto view in memory connector isn't listed in system.jdbc.tables
Steps to reproduce:
```sql
presto> create view memory.default.view1 as select 1 as c1;
CREATE VIEW
presto> select * from system.jdbc.tables where table_cat = 'memory' and table_schem = 'default';
table_cat | table_schem | table_name | table_type... | null | 2020-03-23 11:17:09+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.memory.TestMemoryMetadata.testCreateSchema', 'io.prestosql.plugin.memory.TestMemoryMetadata.testViews', 'io.prestosql.plugin.memory.TestMemoryMetadata.testActiveTableIds', 'io.prestosql.plugin.memory.TestMemoryMetadata.tableAlreadyExists', 'io.prestosql.plugin.memory.TestMemoryMetadata.testCreateV... | ['io.prestosql.plugin.memory.TestMemoryMetadata.testCreatedViewShouldBeListedAsTable'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-memory/src/main/java/io/prestosql/plugin/memory/MemoryMetadata.java->program->class_declaration:MemoryMetadata->method_declaration:listTables"] |
trinodb/trino | 963 | trinodb__trino-963 | ['958'] | 527d00f0355b2da566c44831f6f23762a070d6cc | diff --git a/presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java b/presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java
index 84ed27e24257..de42f534b6c6 100644
--- a/presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java
+++ b/presto-spi... | diff --git a/presto-main/src/test/java/io/prestosql/type/TestDecimalOperators.java b/presto-main/src/test/java/io/prestosql/type/TestDecimalOperators.java
index 8f6e8f4a98de..eeb9702af297 100644
--- a/presto-main/src/test/java/io/prestosql/type/TestDecimalOperators.java
+++ b/presto-main/src/test/java/io/prestosql/type... | Incorrect result for decimal division
```
presto> SELECT cast(1000 as decimal(38,8)) / cast(25 AS decimal(38,8));
_col0
------------
9.16269668
(1 row)
```
It happens because https://github.com/prestosql/presto/blob/master/presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java#L15... | null | 2019-06-11 18:16:48+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.type.TestDecimalOperators.testNegation', 'io.prestosql.type.TestDecimalOperators.testLessThanOrEqual', 'io.prestosql.type.TestDecimalOperators.testGreaterThanOrEqual', 'io.prestosql.type.TestDecimalOperators.testMultiply', 'io.prestosql.type.TestDecimalOperators.testEqual', 'io.prestosql.type.TestDecimal... | ['io.prestosql.type.TestDecimalOperators.testDivide'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 12 | 1 | 13 | false | false | ["presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java->program->class_declaration:UnscaledDecimal128Arithmetic->method_declaration:addUnsignedMultiPrecision", "presto-spi/src/main/java/io/prestosql/spi/type/UnscaledDecimal128Arithmetic.java->program->class_declaration:UnscaledDecimal128Arit... |
trinodb/trino | 1,584 | trinodb__trino-1584 | ['1585'] | 8765c7658d5ed2b1a16d3af87ffb0280fea839ab | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/authentication/HiveMetastoreAuthentication.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/authentication/HiveMetastoreAuthentication.java
index 6c8d6bfdb59b..3d7b3645e63e 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/authentica... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java
index b88efee5f5c3..4c43ca7ae5fa 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java
+++ b/presto-hive/src/test/java/io/prest... | presto select query fails with permission denied for kerberized Hive metastore with hive metastore impersonation enabled.
select query fails when service user and doesn't has read permission to underlaying hdfs directory to hive table. service user can impersonate the actual user who owns the table and directory.
acu... | null | 2019-09-25 15:13:45+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.metastore.cache.TestCachingHiveMetastore.testGetAllTable', 'io.prestosql.plugin.hive.metastore.cache.TestCachingHiveMetastore.testGetPartitionsByNames', 'io.prestosql.plugin.hive.metastore.thrift.TestStaticMetastoreLocator.testFallbackHiveMetastoreWithHiveUser', 'io.prestosql.plugin.hive.meta... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 13 | 6 | 19 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/authentication/KerberosHiveMetastoreAuthentication.java->program->class_declaration:KerberosHiveMetastoreAuthentication->method_declaration:decodeDelegationToken", "presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/thrift/ThriftHiveMetastore.java->program-... |
trinodb/trino | 4,458 | trinodb__trino-4458 | ['4449'] | 277f1543cb16d338a7eaba3c38685218d7dd13bf | diff --git a/presto-hive/pom.xml b/presto-hive/pom.xml
index 38c0bbfe23c3..9ae8bda156e1 100644
--- a/presto-hive/pom.xml
+++ b/presto-hive/pom.xml
@@ -77,6 +77,11 @@
<artifactId>event</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.airlift</groupId>
+ <artifa... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHiveFileSystem.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHiveFileSystem.java
index fce134b8ed21..30a8ddc7bef6 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHiveFileSystem.java
+++ b/pres... | Expose CachingHiveMetastore metrics via JMX
CachingHiveMetastore is available in JMX, however it doesn't include any metrics:
```SQL
select * from jmx.current."presto.plugin.hive.metastore.cache:name=hive,type=cachinghivemetastore";
```
returns something like:
```
node | ... | null | 2020-07-15 15:28:20+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.metastore.cache.TestCachingHiveMetastore.testGetAllTable', 'io.prestosql.plugin.hive.metastore.cache.TestCachingHiveMetastore.testCachingHiveMetastoreCreationWithTtlOnly', 'io.prestosql.plugin.hive.metastore.cache.TestCachingHiveMetastore.testInvalidGetPartitionsByNames', 'io.prestosql.plugin... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 19 | 2 | 21 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/cache/CachingHiveMetastore.java->program->class_declaration:CachingHiveMetastore->method_declaration:CacheStatsMBean_getPartitionNamesStats", "presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/cache/CachingHiveMetastore.java->program->class_decla... |
trinodb/trino | 2,081 | trinodb__trino-2081 | ['1998'] | 14a301a6f79d8ad6eebf5a59856d7e7739624b46 | diff --git a/presto-main/src/main/java/io/prestosql/sql/gen/BytecodeUtils.java b/presto-main/src/main/java/io/prestosql/sql/gen/BytecodeUtils.java
index 95c6fec9db21..b71d6a895ec4 100644
--- a/presto-main/src/main/java/io/prestosql/sql/gen/BytecodeUtils.java
+++ b/presto-main/src/main/java/io/prestosql/sql/gen/Bytecode... | diff --git a/presto-main/src/test/java/io/prestosql/operator/scalar/CustomFunctions.java b/presto-main/src/test/java/io/prestosql/operator/scalar/CustomFunctions.java
index 63a71b6b589d..9ffb1cee2ad4 100644
--- a/presto-main/src/test/java/io/prestosql/operator/scalar/CustomFunctions.java
+++ b/presto-main/src/test/java... | Using dot in ScalarFunctions name value cause failures
We are wring a custom functions like `@ScalarFunction(value = "pretradedate", alias = "default.pretradedate")`. When select on `default.pretradedate`, it throws error
```
io.prestosql.spi.PrestoException: line 1:1: Function default.pretradedate not registered
... | @findepi @martint @Praveen2112 | 2019-11-22 07:35:04+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.operator.scalar.TestCustomFunctions.testCustomAdd', 'io.prestosql.operator.scalar.TestCustomFunctions.testSliceIsNull', 'io.prestosql.operator.scalar.TestCustomFunctions.testLongIsNull'] | ['io.prestosql.operator.scalar.TestCustomFunctions.testIdentityFunction'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-main/src/main/java/io/prestosql/sql/gen/BytecodeUtils.java->program->class_declaration:BytecodeUtils->method_declaration:BytecodeExpression_invoke"] |
trinodb/trino | 3,603 | trinodb__trino-3603 | ['3550'] | 19abcb7ddeacaf1ca7bad52f998b524dc83b6904 | diff --git a/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddLocalExchanges.java b/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddLocalExchanges.java
index 25c568303bfa..fdf64e3e337f 100644
--- a/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddLocalExchanges.... | diff --git a/presto-main/src/test/java/io/prestosql/sql/planner/assertions/RowNumberMatcher.java b/presto-main/src/test/java/io/prestosql/sql/planner/assertions/RowNumberMatcher.java
index f6876120e427..f3daad68bf6a 100644
--- a/presto-main/src/test/java/io/prestosql/sql/planner/assertions/RowNumberMatcher.java
+++ b/p... | Avoid local exchanges around trivial projection
When a projection is below "scrambling" and sorting operations, it's currently surrounded with local exchanges.
For a trivial projection (e.g. pruning), those exchanges are redundant.
```
presto> EXPLAIN SELECT name, row_number() OVER (ORDER BY name) FROM (SELECT * F... | In this particular case this is caused by the fact TopN unconditionally outputs sort symbols (cannot prune).
This causes hiccups in some other places too. I propose that we have a rule that every Node can be pruning.
This seems like a limitation in AddLocalExchanges. For trivial projections (not just those that prun... | 2020-05-03 12:25:16+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testNonSpillableBroadcastJoinAboveTableScan', 'io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testForcePartitioningMarkDistinctInput', 'io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testImplementOffsetWithUnorderedSource', 'io.p... | ['io.prestosql.sql.planner.optimizations.TestAddExchangesPlans.testExchangesAroundTrivialProjection'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Refactoring | false | false | false | true | 1 | 1 | 2 | false | false | ["presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddLocalExchanges.java->program->class_declaration:AddLocalExchanges->class_declaration:Rewriter->method_declaration:PlanWithProperties_visitProject", "presto-main/src/main/java/io/prestosql/sql/planner/optimizations/AddLocalExchanges.java->program->cla... |
trinodb/trino | 3,859 | trinodb__trino-3859 | ['3829'] | 2f902bd6b092fe214a87ded5ca2b2500eff3a7d9 | diff --git a/presto-main/src/main/java/io/prestosql/sql/analyzer/AggregationAnalyzer.java b/presto-main/src/main/java/io/prestosql/sql/analyzer/AggregationAnalyzer.java
index 81ed6bc40779..d216c50e2e31 100644
--- a/presto-main/src/main/java/io/prestosql/sql/analyzer/AggregationAnalyzer.java
+++ b/presto-main/src/main/j... | diff --git a/presto-main/src/test/java/io/prestosql/sql/query/TestFormat.java b/presto-main/src/test/java/io/prestosql/sql/query/TestFormat.java
new file mode 100644
index 000000000000..f6e3e1446414
--- /dev/null
+++ b/presto-main/src/test/java/io/prestosql/sql/query/TestFormat.java
@@ -0,0 +1,53 @@
+package io.prestos... | "Compiler failed" when aggregation is used as an argument to format()
`format` function was added in `315` but it doesn't support aggregations in the expression (and the doc doesn't mention aggregation is not supported, maybe we should consider adding this to the doc for now).
```
select format('%.6f', sum(fees / 1... | ```
presto> select format('%s', sum(nationkey)) from tpch.tiny.nation;
Query 20200522_175544_00011_kci5a failed: Compiler failed
io.prestosql.spi.PrestoException: Compiler failed
at io.prestosql.sql.planner.LocalExecutionPlanner$Visitor.visitScanFilterAndProject(LocalExecutionPlanner.java:1306)
at io.prestosql.s... | 2020-05-26 22:38:57+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.sql.query.TestFormat.testAggregationInFormat'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 2 | 2 | 4 | false | false | ["presto-main/src/main/java/io/prestosql/sql/analyzer/AggregationAnalyzer.java->program->class_declaration:AggregationAnalyzer->class_declaration:Visitor->method_declaration:Boolean_visitFormat", "presto-main/src/main/java/io/prestosql/sql/analyzer/AggregationAnalyzer.java->program->class_declaration:AggregationAnalyze... |
trinodb/trino | 3,437 | trinodb__trino-3437 | ['3436'] | d5bcdf9d0925ab900d9c744e7b76d1bd841f5f62 | diff --git a/presto-orc/src/main/java/io/prestosql/orc/OrcReader.java b/presto-orc/src/main/java/io/prestosql/orc/OrcReader.java
index b9dbaa93b4e9..568fea0553f9 100644
--- a/presto-orc/src/main/java/io/prestosql/orc/OrcReader.java
+++ b/presto-orc/src/main/java/io/prestosql/orc/OrcReader.java
@@ -182,7 +182,7 @@ priva... | diff --git a/presto-orc/src/test/java/io/prestosql/orc/OrcTester.java b/presto-orc/src/test/java/io/prestosql/orc/OrcTester.java
index 0d292f96d819..dcff9619eb95 100644
--- a/presto-orc/src/test/java/io/prestosql/orc/OrcTester.java
+++ b/presto-orc/src/test/java/io/prestosql/orc/OrcTester.java
@@ -573,7 +573,7 @@ stati... | Reading data after minor compaction fails in full ACID tables
Such reads fails with: "io.prestosql.spi.PrestoException: Error opening Hive split hdfs://hadoop-master:9000/user/hive/warehouse/test2/delta_0000001_0000002/bucket_00000 (offset=0, length=16054): rowsInRowGroup must be greater than zero"
This happens beca... | null | 2020-04-15 08:11:49+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.orc.TestReadBloomFilter.test'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 8 | 6 | 14 | false | false | ["presto-orc/src/main/java/io/prestosql/orc/metadata/Footer.java->program->class_declaration:Footer->constructor_declaration:Footer", "presto-orc/src/main/java/io/prestosql/orc/metadata/OrcMetadataWriter.java->program->class_declaration:OrcMetadataWriter->method_declaration:writeFooter", "presto-orc/src/main/java/io/pr... |
trinodb/trino | 5,661 | trinodb__trino-5661 | ['5660'] | e9be099acc53b8f08e11e3a47d9cd1c23b283326 | diff --git a/presto-main/src/main/java/io/prestosql/sql/analyzer/CanonicalizationAware.java b/presto-main/src/main/java/io/prestosql/sql/analyzer/CanonicalizationAware.java
index d8b7917c8d82..affecc096aed 100644
--- a/presto-main/src/main/java/io/prestosql/sql/analyzer/CanonicalizationAware.java
+++ b/presto-main/src/... | diff --git a/presto-main/src/test/java/io/prestosql/sql/analyzer/TestAnalyzer.java b/presto-main/src/test/java/io/prestosql/sql/analyzer/TestAnalyzer.java
index fc49c3dedefe..b857d41d6184 100644
--- a/presto-main/src/test/java/io/prestosql/sql/analyzer/TestAnalyzer.java
+++ b/presto-main/src/test/java/io/prestosql/sql/... | Improper resolution for fully qualified reference to field from inner query
This query should fail because `t` is not in scope for the outer query:
```sql
SELECT t.a FROM (
SELECT * FROM (VALUES 1) t(a)
);
```
| null | 2020-10-22 19:47:38+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.sql.analyzer.TestAnalyzer.testGroupingTooManyArguments', 'io.prestosql.sql.analyzer.TestAnalyzer.testNotNullInJoinClause', 'io.prestosql.sql.analyzer.TestAnalyzer.testNonAggregationDistinct', 'io.prestosql.sql.analyzer.TestAnalyzer.testInvalidAttribute', 'io.prestosql.sql.analyzer.TestAnalyzer.testInVali... | ['io.prestosql.sql.analyzer.TestAnalyzer.testSelectAllColumns', 'io.prestosql.sql.analyzer.TestAnalyzer.testOrderByWithWildcard'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["presto-main/src/main/java/io/prestosql/sql/analyzer/StatementAnalyzer.java->program->class_declaration:StatementAnalyzer->class_declaration:Visitor->method_declaration:Scope_computeAndAssignOutputScope", "presto-main/src/main/java/io/prestosql/sql/analyzer/StatementAnalyzer.java->program->class_declaration:StatementA... |
trinodb/trino | 1,512 | trinodb__trino-1512 | ['1510'] | 0637de3ef0b5873b285a62a72ddb82505c707bb3 | diff --git a/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/HashGenerationOptimizer.java b/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/HashGenerationOptimizer.java
index c541a6b76c5b..0152699f6ee3 100644
--- a/presto-main/src/main/java/io/prestosql/sql/planner/optimizations/HashGe... | diff --git a/presto-main/src/test/java/io/prestosql/sql/planner/TestLogicalPlanner.java b/presto-main/src/test/java/io/prestosql/sql/planner/TestLogicalPlanner.java
index 35fac9f0b56e..093ad8a97ab8 100644
--- a/presto-main/src/test/java/io/prestosql/sql/planner/TestLogicalPlanner.java
+++ b/presto-main/src/test/java/io... | Multiple entries failure in HashGenerationOptimizer
# Problem
From 318, the following error happens when we use aggregation with the union and distinct.
```
Multiple entries with same key: HashComputation{fields=[expr_62]}=HashComputation{fields=[expr_47]} and HashComputation{fields=[expr_62]}=HashComputation{fi... | In that case can we go for a `MultiMap` for handing this so duplicate entries can be handled
@Praveen2112 Thank you for the response.
Yes, but how can we look up the computed hash when using `MultiMap`? There are multiple possible hashes returned by `lookup`. Sorry, I do not fully understand the background of the ... | 2019-09-13 06:44:28+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.sql.planner.TestLogicalPlanner.testAggregation', 'io.prestosql.sql.planner.TestLogicalPlanner.testRemoveUnreferencedScalarInputApplyNodes', 'io.prestosql.sql.planner.TestLogicalPlanner.testRemoveSingleRowSort', 'io.prestosql.sql.planner.TestLogicalPlanner.testRemoveAggregationInSemiJoin', 'io.prestosql.s... | ['io.prestosql.sql.query.TestPrecomputedHashes.testUnionAllAndDistinctLimit', 'io.prestosql.sql.planner.TestLogicalPlanner.testRedundantHashRemovalForUnionAllAndMarkDistinct'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 4 | 2 | 6 | false | false | ["presto-main/src/main/java/io/prestosql/sql/planner/optimizations/HashGenerationOptimizer.java->program->class_declaration:HashGenerationOptimizer->class_declaration:HashComputationSet->method_declaration:HashComputationSet_pruneSymbols", "presto-main/src/main/java/io/prestosql/sql/planner/optimizations/HashGeneration... |
trinodb/trino | 799 | trinodb__trino-799 | ['680'] | 8c447eaba401f0dfb7b2867674e301bbb2ccdc06 | diff --git a/presto-main/src/main/java/io/prestosql/execution/resourcegroups/IndexedPriorityQueue.java b/presto-main/src/main/java/io/prestosql/execution/resourcegroups/IndexedPriorityQueue.java
index ebef17b7f6d2..e8dc64e78792 100644
--- a/presto-main/src/main/java/io/prestosql/execution/resourcegroups/IndexedPriority... | diff --git a/presto-main/src/test/java/io/prestosql/execution/TestNodeScheduler.java b/presto-main/src/test/java/io/prestosql/execution/TestNodeScheduler.java
index 4883a055cf60..f65e266e7a12 100644
--- a/presto-main/src/test/java/io/prestosql/execution/TestNodeScheduler.java
+++ b/presto-main/src/test/java/io/prestosq... | Data locality based scheduling of source splits with uniform distribution of load
For cases where Presto workers are co-located with the data (actual or cache), we want to maximize local reads by assigning source splits to workers which contain the data for that split. But we do not want to do this at the cost of lower... | null | 2019-05-21 07:05:10+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.execution.TestNodeSchedulerConfig.testExplicitPropertyMappings', 'io.prestosql.execution.TestNodeScheduler.testEquateDistribution', 'io.prestosql.execution.TestNodeScheduler.testBasicAssignment', 'io.prestosql.execution.TestNodeScheduler.testEmptyAssignmentWithFullNodes', 'io.prestosql.execution.TestNode... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 8 | 7 | 15 | false | false | ["presto-main/src/main/java/io/prestosql/execution/scheduler/NodeSchedulerConfig.java->program->class_declaration:NodeSchedulerConfig", "presto-main/src/main/java/io/prestosql/execution/scheduler/SimpleNodeSelector.java->program->class_declaration:SimpleNodeSelector->method_declaration:SplitPlacementResult_computeAssig... |
trinodb/trino | 4,600 | trinodb__trino-4600 | ['4553'] | 9bc01164ad67510e363fe2d5fec273ca828d2fe0 | diff --git a/presto-client/src/main/java/io/prestosql/client/StageStats.java b/presto-client/src/main/java/io/prestosql/client/StageStats.java
index e60c4e276e5d..379c04d0be53 100644
--- a/presto-client/src/main/java/io/prestosql/client/StageStats.java
+++ b/presto-client/src/main/java/io/prestosql/client/StageStats.ja... | diff --git a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestProgressMonitor.java b/presto-jdbc/src/test/java/io/prestosql/jdbc/TestProgressMonitor.java
index aec5e9a17c4a..aff2523f4ff7 100644
--- a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestProgressMonitor.java
+++ b/presto-jdbc/src/test/java/io/prestosql/jdbc/Te... | Add physicalInputDataSize to StatementStats
In https://github.com/prestosql/presto/pull/4354 `physicalInputDataSize` was added to `BasicQueryStats`. We should also add the same to `StatementStats` so that the query API response includes data scan stats.
Discussed at https://prestosql.slack.com/archives/CFPVDCDHV/p15... | null | 2020-07-27 15:23:36+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.jdbc.TestProgressMonitor.test'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 10 | 6 | 16 | false | false | ["presto-client/src/main/java/io/prestosql/client/StageStats.java->program->class_declaration:StageStats->method_declaration:String_toString", "presto-main/src/main/java/io/prestosql/server/protocol/Query.java->program->class_declaration:Query->method_declaration:StageStats_toStageStats", "presto-client/src/main/java/i... |
trinodb/trino | 725 | trinodb__trino-725 | ['724'] | 450aca024111f45dd0aaded007963d407fda3177 | diff --git a/presto-main/src/main/java/io/prestosql/memory/MemoryPool.java b/presto-main/src/main/java/io/prestosql/memory/MemoryPool.java
index d3b8082370c2..7e470328b00f 100644
--- a/presto-main/src/main/java/io/prestosql/memory/MemoryPool.java
+++ b/presto-main/src/main/java/io/prestosql/memory/MemoryPool.java
@@ -1... | diff --git a/presto-main/src/test/java/io/prestosql/memory/TestMemoryPools.java b/presto-main/src/test/java/io/prestosql/memory/TestMemoryPools.java
index c4aae2800fed..83d361571657 100644
--- a/presto-main/src/test/java/io/prestosql/memory/TestMemoryPools.java
+++ b/presto-main/src/test/java/io/prestosql/memory/TestMe... | NullPointerException when local memory limits are exceeded
Getting this when local memory limits are exceeded (intermittently) on Presto 308:
```
java.lang.NullPointerException: null value in entry: 20190430_043249_01003_x7dxw=null
at com.google.common.collect.CollectPreconditions.checkEntryNotNull(CollectPrecondit... | null | 2019-05-07 17:45:48+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.memory.TestMemoryPools.testBlockingOnRevocableMemoryFreeViaRevoke', 'io.prestosql.memory.TestMemoryPools.testMemoryFutureCancellation', 'io.prestosql.memory.TestMemoryPools.testTaggedAllocations', 'io.prestosql.memory.TestMemoryPools.testBlockingOnUserMemory', 'io.prestosql.memory.TestMemoryPools.testMov... | ['io.prestosql.memory.TestMemoryPools.testMoveUnknownQuery'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-main/src/main/java/io/prestosql/memory/MemoryPool.java->program->class_declaration:MemoryPool->method_declaration:moveQuery"] |
trinodb/trino | 2,768 | trinodb__trino-2768 | ['2767'] | b749331afcdaf917bbf2530c03f8a6a1d39b80fa | diff --git a/presto-main/src/main/java/io/prestosql/execution/CreateRoleTask.java b/presto-main/src/main/java/io/prestosql/execution/CreateRoleTask.java
index f37eca3d2334..40e0292dc289 100644
--- a/presto-main/src/main/java/io/prestosql/execution/CreateRoleTask.java
+++ b/presto-main/src/main/java/io/prestosql/executi... | diff --git a/presto-main/src/test/java/io/prestosql/execution/TestSetRoleTask.java b/presto-main/src/test/java/io/prestosql/execution/TestSetRoleTask.java
index 7bfb9f25cbaa..f17703475d0f 100644
--- a/presto-main/src/test/java/io/prestosql/execution/TestSetRoleTask.java
+++ b/presto-main/src/test/java/io/prestosql/exec... | USE fails when in an invalid catalog when a role for that catalog is set
```
$ presto --debug --catalog test
presto> set role admin;
SET ROLE
presto> use tpch.tiny;
Query 20200208_184255_00004_a53s9 failed: Catalog does not exist: test
io.prestosql.spi.PrestoException: Catalog does not exist: test
at io.... | null | 2020-02-08 18:56:05+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.execution.TestSetRoleTask.testSetRole'] | ['io.prestosql.execution.TestSetRoleTask.testSetRoleInvalidCatalog'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 7 | 0 | 7 | false | false | ["presto-main/src/main/java/io/prestosql/metadata/MetadataUtil.java->program->class_declaration:MetadataUtil->method_declaration:String_createCatalogName", "presto-main/src/main/java/io/prestosql/execution/GrantRolesTask.java->program->class_declaration:GrantRolesTask->method_declaration:execute", "presto-main/src/main... |
trinodb/trino | 3,392 | trinodb__trino-3392 | ['3394'] | 840d589dbb3c389abfea8d08bdb0d496431cf97f | diff --git a/presto-docs/src/main/sphinx/functions/list.rst b/presto-docs/src/main/sphinx/functions/list.rst
index 8fa185d0c5be..5295e7f381bd 100644
--- a/presto-docs/src/main/sphinx/functions/list.rst
+++ b/presto-docs/src/main/sphinx/functions/list.rst
@@ -390,6 +390,7 @@ S
- :func:`ST_Y`
- :func:`ST_YMax`
- :func... | diff --git a/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java b/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java
index 850df620e364..38b636ef1763 100644
--- a/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java
+++ b/presto-main/s... | Add the starts_with function to determine whether a string starts with a pattern
In our use case, we mainly use `position()` function to determine whether a string starts with a pattern.
However, `position()` function is a little inefficient to determine it.
As far as I investigate, regardless of the length of 1s... | null | 2020-04-09 11:45:50+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.operator.scalar.TestStringFunctions.testCharLength', 'io.prestosql.operator.scalar.TestStringFunctions.testSubstring', 'io.prestosql.operator.scalar.TestStringFunctions.testCharSubstring', 'io.prestosql.operator.scalar.TestStringFunctions.testNormalize', 'io.prestosql.operator.scalar.TestStringFunctions.... | ['io.prestosql.operator.scalar.TestStringFunctions.testStringPosition'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 1 | 1 | 2 | false | false | ["presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java->program->class_declaration:StringFunctions->method_declaration:startsWith", "presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java->program->class_declaration:StringFunctions"] |
trinodb/trino | 2,226 | trinodb__trino-2226 | ['2130'] | ae87306d7c1b1a6c613db4b1032619fb9708526f | diff --git a/presto-main/pom.xml b/presto-main/pom.xml
index bfda52c0ec51..0eb7e5b831d3 100644
--- a/presto-main/pom.xml
+++ b/presto-main/pom.xml
@@ -318,6 +318,7 @@
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
+ <version>3.13.2</versio... | diff --git a/presto-main/src/test/java/io/prestosql/sql/analyzer/TestTypeSignatureTranslator.java b/presto-main/src/test/java/io/prestosql/sql/analyzer/TestTypeSignatureTranslator.java
new file mode 100644
index 000000000000..8bebc94f1ed0
--- /dev/null
+++ b/presto-main/src/test/java/io/prestosql/sql/analyzer/TestTypeS... | SHOW CREATE TABLE for row type match reserved SQL keywords fails
Steps to reproduce:
```sql
presto> create table memory.default.test (c1 row("from" integer));
CREATE TABLE
presto> show columns in memory.default.test;
Column | Type | Extra | Comment
--------+-------------------+-------+---------
... | null | 2019-12-07 12:31:44+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.sql.analyzer.TestTypeSignatureTranslator.testIntervalTypes', 'io.prestosql.sql.analyzer.TestTypeSignatureTranslator.testDayTimeTypes', 'io.prestosql.sql.analyzer.TestTypeSignatureTranslator.testComplexTypes', 'io.prestosql.sql.analyzer.TestTypeSignatureTranslator.testSimpleTypes', 'io.prestosql.sql.analy... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 2 | 13 | 15 | false | false | ["presto-parser/src/main/java/io/prestosql/sql/tree/DateTimeDataType.java->program->class_declaration:DateTimeDataType", "presto-parser/src/main/java/io/prestosql/sql/tree/IntervalDayTimeDataType.java->program->class_declaration:IntervalDayTimeDataType", "presto-parser/src/main/java/io/prestosql/sql/tree/RowDataType.ja... |
trinodb/trino | 748 | trinodb__trino-748 | ['726'] | e0c2cb7621bc8b55c423f023b659f2050f93e9ed | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java
index dba6594e0586..226588ed24ea 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetasto... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/glue/TestGlueHiveMetastoreConfig.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/glue/TestGlueHiveMetastoreConfig.java
index b63b0b5d39fc..5bbd14f78661 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/... | Accessing AWS Glue Catalog in different account using presto
Well, this is not an issue but I am trying to access aws glue catalog using presto which is situated in a different account. I can access the Glue catalog in the account where the presto instance is running using the below configuration:
connector.name=hiv... | This is a current limitation, but should be easy to add. If you're interested in working on this yourself, it should be just adding them to `GlueHiveMetastoreConfig` and using them in `GlueHiveMetastore` to create the AWS client (with a `BasicAWSCredentials`).
In the latest `310` release, we did add `hive.metastore.... | 2019-05-11 20:31:24+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.metastore.glue.TestGlueHiveMetastoreConfig.testExplicitPropertyMapping', 'io.prestosql.plugin.hive.metastore.glue.TestGlueHiveMetastoreConfig.testDefaults'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 5 | 1 | 6 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastoreConfig.java->program->class_declaration:GlueHiveMetastoreConfig->method_declaration:getAwsSecretKey", "presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/glue/GlueHiveMetastore.java->program->class_declaration:GlueHiveMetasto... |
trinodb/trino | 2,575 | trinodb__trino-2575 | ['2523'] | d5cb276cd8ac6c8eb321c0d32c018d90537e1eff | diff --git a/presto-main/src/main/java/io/prestosql/connector/informationschema/InformationSchemaMetadata.java b/presto-main/src/main/java/io/prestosql/connector/informationschema/InformationSchemaMetadata.java
index 1981e3092f90..88829b4f480a 100644
--- a/presto-main/src/main/java/io/prestosql/connector/informationsch... | diff --git a/presto-main/src/test/java/io/prestosql/metadata/TestInformationSchemaMetadata.java b/presto-main/src/test/java/io/prestosql/metadata/TestInformationSchemaMetadata.java
index 38a4bd7445ee..5f256f3da796 100644
--- a/presto-main/src/test/java/io/prestosql/metadata/TestInformationSchemaMetadata.java
+++ b/pres... | Error when querying information schema with empty table_name predicate
```
select * from "hive"."information_schema"."tables" WHERE table_schema='tpch' AND table_name=''
```
Is causing:
```
java.lang.IllegalArgumentException: tableName is empty
at io.prestosql.spi.connector.SchemaUtil.checkNotEmpty(SchemaUtil.... | I think this kind of query should evaluate to empty relation during the planning. | 2020-01-22 06:35:19+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.metadata.TestInformationSchemaMetadata.testInformationSchemaPredicatePushdownOnCatalogWiseTables', 'io.prestosql.metadata.TestInformationSchemaMetadata.testInformationSchemaPredicatePushdownWithoutTablePredicate', 'io.prestosql.metadata.TestInformationSchemaMetadata.testInformationSchemaPredicatePushdown... | ['io.prestosql.metadata.TestInformationSchemaMetadata.testInformationSchemaPredicatePushdownForEmptyNames'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 4 | 1 | 5 | false | false | ["presto-main/src/main/java/io/prestosql/connector/informationschema/InformationSchemaMetadata.java->program->class_declaration:InformationSchemaMetadata->method_declaration:calculatePrefixesWithSchemaName", "presto-main/src/main/java/io/prestosql/connector/informationschema/InformationSchemaMetadata.java->program->cla... |
trinodb/trino | 2,118 | trinodb__trino-2118 | ['2115'] | 75044d66dd301e0564b8e84868fd6fab9b02729b | diff --git a/presto-google-sheets/src/main/java/io/prestosql/plugin/google/sheets/SheetsMetadata.java b/presto-google-sheets/src/main/java/io/prestosql/plugin/google/sheets/SheetsMetadata.java
index 42db557732a1..86894f95829f 100644
--- a/presto-google-sheets/src/main/java/io/prestosql/plugin/google/sheets/SheetsMetada... | diff --git a/presto-google-sheets/src/test/java/io/prestosql/plugin/google/sheets/TestGoogleSheets.java b/presto-google-sheets/src/test/java/io/prestosql/plugin/google/sheets/TestGoogleSheets.java
index 93c2cbf7f76e..5eab84d2d78b 100644
--- a/presto-google-sheets/src/test/java/io/prestosql/plugin/google/sheets/TestGoog... | Google Sheets connector's information_schema contains wrong tables
It may be specific to gsheets-connector, but `information_schema` schema shows tables from `default` schema as well. It shouldn't.
```
Vikrants-MacBook-Pro:presto-cli-325 vikrant.goel$ ./presto --catalog sheets --schema information_schema
presto:in... | null | 2019-11-27 02:48:10+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.google.sheets.TestGoogleSheets.testSelectFromTableIgnoreCase', 'io.prestosql.plugin.google.sheets.TestGoogleSheets.testQueryingUnknownSchemaAndTable', 'io.prestosql.plugin.google.sheets.TestGoogleSheets.testDescTable', 'io.prestosql.plugin.google.sheets.TestGoogleSheets.testSelectFromTable', 'io.p... | ['io.prestosql.plugin.google.sheets.TestGoogleSheets.testListTable'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-google-sheets/src/main/java/io/prestosql/plugin/google/sheets/SheetsMetadata.java->program->class_declaration:SheetsMetadata->method_declaration:listTables"] |
trinodb/trino | 3,638 | trinodb__trino-3638 | ['2493'] | 3344fd7cc280bef364fc3f50a7f2b5ba91cf9042 | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConfig.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConfig.java
index 31da98d177ef..6463d6ef93f0 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConfig.java
+++ b/presto-hive/src/main/java/io/prestosql/plugin/hive/H... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java
index 24d0dc4b97f0..3fbe4238ffc4 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/AbstractTestHive.java
+++ b/presto-hive/src/test/java/io/prest... | Make stats update parallel in Hive connector
Currently, stats are updated in sequence which takes a lot of time if there are many partitions. This should be parallelized in order to reduce INSERT or ANALYZE latency.
| null | 2020-05-06 05:51:22+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.metastore.TestSemiTransactionalHiveMetastore.testParallelUpdateStatisticsOperations', 'io.prestosql.plugin.hive.metastore.TestSemiTransactionalHiveMetastore.testParallelPartitionDrops', 'io.prestosql.plugin.hive.TestHiveConfig.testExplicitPropertyMappings', 'io.prestosql.plugin.hive.TestHiveC... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 7 | 5 | 12 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/HiveConfig.java->program->class_declaration:HiveConfig", "presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadataFactory.java->program->class_declaration:HiveMetadataFactory->constructor_declaration:HiveMetadataFactory", "presto-hive/src/main/java/io/prestosq... |
trinodb/trino | 5,010 | trinodb__trino-5010 | ['5002'] | 6a1633fb04e410fef385b0b26ba5998bab0dc92b | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3FileSystem.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3FileSystem.java
index 7789085c2daa..dec7e87b9a3f 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3FileSystem.java
+++ b/presto-hive/src/mai... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/MockAmazonS3.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/MockAmazonS3.java
index 7465e5e0f25d..7fc04342ace4 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/s3/MockAmazonS3.java
+++ b/presto-hive/src/test/java/io/prestosq... | PrestoS3FileSystem should skip DeepArchive in addition to Glacier
The `skip-glacier-objects` config is intended to skip all Glacier objects and thus should apply to both storage classes.
| null | 2020-08-28 13:56:30+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testPathStyleAccess', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testReadNotFound', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testUnrecoverableS3ExceptionMessage', 'io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testKMSEncryptionMaterialsProvid... | ['io.prestosql.plugin.hive.s3.TestPrestoS3FileSystem.testSkipGlacierObjectsEnabled'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 1 | 1 | 2 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3FileSystem.java->program->class_declaration:PrestoS3FileSystem", "presto-hive/src/main/java/io/prestosql/plugin/hive/s3/PrestoS3FileSystem.java->program->class_declaration:PrestoS3FileSystem->method_declaration:isGlacierObject"] |
trinodb/trino | 3,599 | trinodb__trino-3599 | ['3456'] | ca8922eaeb0ad9da60c0856827ff747589775ae5 | diff --git a/presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java b/presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java
index 2fb86d047f8a..983b1418839d 100644
--- a/presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java
+++ b/presto-main/src/main/java... | diff --git a/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java b/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java
index da44808cdd97..fcf6407cb9b9 100644
--- a/presto-main/src/test/java/io/prestosql/operator/scalar/TestStringFunctions.java
+++ b/presto-main/s... | Substr to a CHAR(n) column returns padded string
## Problem
When I do substr to a fixed length CHAR(n) column, it returns white-space-padded string. But I think it should return a truncated string without padding.
I've done the same thing in MySQL and it returned a truncated string which I expected for.
## How t... | I need to take another look at the SQL specification, but this seems like the correct and expected behavior.
CHAR(n) is a fixed-length type (as opposed to VARCHAR(n). The result of applying substr to a CHAR(n) is, by necessity, of the same type — the type system is not powerful enough to derive a new type based on the... | 2020-05-02 09:51:55+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.operator.scalar.TestStringFunctions.testCharLength', 'io.prestosql.operator.scalar.TestStringFunctions.testSubstring', 'io.prestosql.operator.scalar.TestStringFunctions.testNormalize', 'io.prestosql.operator.scalar.TestStringFunctions.testTrimParametrized', 'io.prestosql.operator.scalar.TestStringFunctio... | ['io.prestosql.operator.scalar.TestStringFunctions.testCharSubstring'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-main/src/main/java/io/prestosql/operator/scalar/StringFunctions.java->program->class_declaration:StringFunctions->method_declaration:Slice_charSubstr"] |
trinodb/trino | 2,632 | trinodb__trino-2632 | ['2593'] | 1d79fe1948a9314c651f793e9366e3d50cee8f04 | diff --git a/presto-main/src/main/java/io/prestosql/sql/rewrite/ShowQueriesRewrite.java b/presto-main/src/main/java/io/prestosql/sql/rewrite/ShowQueriesRewrite.java
index 356e3e8f002d..e2c79a72ef7e 100644
--- a/presto-main/src/main/java/io/prestosql/sql/rewrite/ShowQueriesRewrite.java
+++ b/presto-main/src/main/java/io... | diff --git a/presto-main/src/main/java/io/prestosql/testing/TestingAccessControlManager.java b/presto-main/src/main/java/io/prestosql/testing/TestingAccessControlManager.java
index 91ab9a4551f8..ac894c02480e 100644
--- a/presto-main/src/main/java/io/prestosql/testing/TestingAccessControlManager.java
+++ b/presto-main/s... | SHOW CATALOGS fails with "Internal error" when all catalogs filtered out by access control
There always is a catalog. If nothing is installed, there is a `system` catalog.
However, `AccessControl` may legitimately filter it out.
Then --
```
presto:default> SHOW CATALOGS;
Query 20200123_103158_00002_4u426 failed:... | The issue is that the rewrite is creating a VALUES syntax node with no rows.
The long-term fix for this is to add first-class support for `SHOW xxx` to the planner instead of relying on syntactic rewrites and create an empty ValuesNode directly. In the short term, we'll have to fix it by synthesizing a `VALUES` wit... | 2020-01-26 11:33:43+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.sql.query.TestShowQueries.testShowSessionLikeWithEscape', 'io.prestosql.sql.query.TestShowQueries.testShowSessionLike', 'io.prestosql.sql.query.TestShowQueries.testShowFunctionsLikeWithEscape', 'io.prestosql.sql.query.TestShowQueries.testShowFunctionLike'] | ['io.prestosql.sql.query.TestShowQueries.testShowCatalogsLikeWithEscape', 'io.prestosql.sql.query.TestShowQueries.testListingEmptyCatalogs'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-main/src/main/java/io/prestosql/sql/rewrite/ShowQueriesRewrite.java->program->class_declaration:ShowQueriesRewrite->class_declaration:Visitor->method_declaration:Node_visitShowCatalogs"] |
trinodb/trino | 3,725 | trinodb__trino-3725 | ['3716'] | f4d7de398006aca2bccf84b5e59d69e93cf51a58 | diff --git a/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergPageSource.java b/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergPageSource.java
index 4fc0262d9a7b..6029f309228b 100644
--- a/presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergPageSource.java
+++ b/presto-iceber... | diff --git a/presto-iceberg/src/test/java/io/prestosql/plugin/iceberg/TestIcebergSmoke.java b/presto-iceberg/src/test/java/io/prestosql/plugin/iceberg/TestIcebergSmoke.java
index 8a10fe006074..71c4df3392e2 100644
--- a/presto-iceberg/src/test/java/io/prestosql/plugin/iceberg/TestIcebergSmoke.java
+++ b/presto-iceberg/s... | IcebergConnector: Handle `null` partition value
If the partition value is null.
here if partition column value is null. it fails with exception.
```File hdfs://abc.parquet has no partition data for partitioning column event_dt\```
Place from where this condition is checked:
```
private static Map<Integer... | null | 2020-05-13 21:39:56+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.iceberg.TestIcebergSmoke.testExactPredicate', 'io.prestosql.plugin.iceberg.TestIcebergSmoke.testSelectInformationSchemaTables', 'io.prestosql.plugin.iceberg.TestIcebergSmoke.testConcurrentScans', 'io.prestosql.plugin.iceberg.TestIcebergSmoke.ensureDistributedQueryRunner', 'io.prestosql.plugin.iceb... | ['io.prestosql.plugin.iceberg.TestIcebergSmoke.testCreatePartitionedTable'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 2 | 2 | 4 | false | false | ["presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergPageSource.java->program->class_declaration:IcebergPageSource->constructor_declaration:IcebergPageSource", "presto-iceberg/src/main/java/io/prestosql/plugin/iceberg/IcebergPageSource.java->program->class_declaration:IcebergPageSource->method_declaration:... |
trinodb/trino | 1,193 | trinodb__trino-1193 | ['1189'] | eb1779efb4a9ca1f48682bb9e4da1f993f683069 | diff --git a/presto-main/src/main/java/io/prestosql/dispatcher/DispatcherConfig.java b/presto-main/src/main/java/io/prestosql/dispatcher/DispatcherConfig.java
index 9fbb67394901..aa3878ae978f 100644
--- a/presto-main/src/main/java/io/prestosql/dispatcher/DispatcherConfig.java
+++ b/presto-main/src/main/java/io/prestosq... | diff --git a/presto-main/src/test/java/io/prestosql/dispatcher/TestDispatcherConfig.java b/presto-main/src/test/java/io/prestosql/dispatcher/TestDispatcherConfig.java
index 5460a996c597..1077619d4292 100644
--- a/presto-main/src/test/java/io/prestosql/dispatcher/TestDispatcherConfig.java
+++ b/presto-main/src/test/java... | Support for X-Forwarded-For breaks existing behavior
After upgrading to the latest build, existing installation does not work and connections are rejected with "Presto is configured to REJECT this header: X-Forwarded-For". It is not clear why the default is REJECT and not IGNORE, so it preserves the functionality. If ... | @vrozov
thank you for your feedback. Please accept apologies that I broke your installation.
First, the simple thing:
> Additionally, `dispatcher.forwarded-header` should _not_ be case sensitive and should equally accept `ignore` or `accept`.
This is standard behavior for config values that are backed by a J... | 2019-07-26 07:23:16+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.dispatcher.TestDispatcherConfig.testDefaults', 'io.prestosql.server.TestHttpRequestSessionContext.testSessionContext', 'io.prestosql.server.TestHttpRequestSessionContext.testPreparedStatementsHeaderDoesNotParse', 'io.prestosql.server.TestHttpRequestSessionContext.testXForwardedFor', 'io.prestosql.server.... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 2 | 2 | 4 | false | false | ["presto-main/src/main/java/io/prestosql/dispatcher/DispatcherConfig.java->program->class_declaration:DispatcherConfig", "presto-main/src/main/java/io/prestosql/server/HttpRequestSessionContext.java->program->class_declaration:HttpRequestSessionContext", "presto-main/src/main/java/io/prestosql/dispatcher/DispatcherConf... |
trinodb/trino | 3,771 | trinodb__trino-3771 | ['3220'] | 73aa2888afe85abf4faa0403eecab93dc89ca214 | diff --git a/presto-docs/src/main/sphinx/connector/hive.rst b/presto-docs/src/main/sphinx/connector/hive.rst
index fde819b5d5c2..134cc29e0c85 100644
--- a/presto-docs/src/main/sphinx/connector/hive.rst
+++ b/presto-docs/src/main/sphinx/connector/hive.rst
@@ -249,48 +249,52 @@ Property Name ... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/thrift/TestThriftMetastoreConfig.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/thrift/TestThriftMetastoreConfig.java
index c551e8b333bf..571b02ff83d6 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/metastore/... | Reduce numbers to issue delegation tokens for kerberized HMS
Currently, Hive connector creates new delegation tokens per request, but our Zookeeper sometimes cannot handle those many requests. This issue may happen especially when we use `information_schema.columns` tables.
We are going to use HMS cache, but it wou... | null | 2020-05-18 13:17:30+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.metastore.thrift.TestThriftMetastoreConfig.testDefaults', 'io.prestosql.plugin.hive.metastore.thrift.TestThriftMetastoreConfig.testExplicitPropertyMappings'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 6 | 3 | 9 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/thrift/ThriftHiveMetastore.java->program->class_declaration:ThriftHiveMetastore->method_declaration:String_loadDelegationToken", "presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/thrift/ThriftMetastoreConfig.java->program->class_declaration:Thri... |
trinodb/trino | 6,074 | trinodb__trino-6074 | ['5955'] | e95dac7347df3ab31a69298c5d3904cab45f5e02 | diff --git a/presto-kafka/src/main/java/io/prestosql/plugin/kafka/encoder/json/format/MillisecondsSinceEpochFormatter.java b/presto-kafka/src/main/java/io/prestosql/plugin/kafka/encoder/json/format/MillisecondsSinceEpochFormatter.java
index cb9f2affb839..9973122ae251 100644
--- a/presto-kafka/src/main/java/io/prestosql... | diff --git a/presto-kafka/src/test/java/io/prestosql/plugin/kafka/encoder/json/TestJsonEncoder.java b/presto-kafka/src/test/java/io/prestosql/plugin/kafka/encoder/json/TestJsonEncoder.java
index 6b600c7ac900..fdeb09f2454d 100644
--- a/presto-kafka/src/test/java/io/prestosql/plugin/kafka/encoder/json/TestJsonEncoder.jav... | Extend support for INSERT TIME/TIMESTAMP WITH TIMEZONE in Kafka connector JSON encoder
Allow INSERT of temporal types with time-zone in Kafka connector with JSON Encoder when using the `milliseconds-since-epoch` or `seconds-since-epoch` formatters.
See discussion at https://github.com/prestosql/presto/pull/5838#disc... | null | 2020-11-24 13:02:22+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.plugin.kafka.encoder.json.TestSecondsJsonDateTimeFormatter.testTime', 'io.prestosql.plugin.kafka.encoder.json.TestMillisecondsJsonDateTimeFormatter.testTimestamp', 'io.prestosql.plugin.kafka.encoder.json.TestSecondsJsonDateTimeFormatter.testTimestamp', 'io.prestosql.plugin.kafka.encoder.json.TestMillisec... | ['io.prestosql.plugin.kafka.encoder.json.TestSecondsJsonDateTimeFormatter.testTimestampWithTimeZone', 'io.prestosql.plugin.kafka.encoder.json.TestJsonEncoder.testColumnValidation', 'io.prestosql.plugin.kafka.encoder.json.TestMillisecondsJsonDateTimeFormatter.testTimestampWithTimeZone'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 4 | 2 | 6 | false | false | ["presto-kafka/src/main/java/io/prestosql/plugin/kafka/encoder/json/format/SecondsSinceEpochFormatter.java->program->class_declaration:SecondsSinceEpochFormatter->method_declaration:isSupportedType", "presto-kafka/src/main/java/io/prestosql/plugin/kafka/encoder/json/format/SecondsSinceEpochFormatter.java->program->clas... |
trinodb/trino | 4,664 | trinodb__trino-4664 | ['4630'] | 417c859c257dfd1a135aa38a8ccba161400f1b28 | diff --git a/presto-docs/src/main/sphinx/connector/kafka.rst b/presto-docs/src/main/sphinx/connector/kafka.rst
index ef9c5050fb41..5c75b894f057 100644
--- a/presto-docs/src/main/sphinx/connector/kafka.rst
+++ b/presto-docs/src/main/sphinx/connector/kafka.rst
@@ -62,7 +62,6 @@ Property Name Description... | diff --git a/presto-kafka/src/test/java/io/prestosql/plugin/kafka/KafkaQueryRunner.java b/presto-kafka/src/test/java/io/prestosql/plugin/kafka/KafkaQueryRunner.java
index b43d66e2742b..d9d681afbe59 100644
--- a/presto-kafka/src/test/java/io/prestosql/plugin/kafka/KafkaQueryRunner.java
+++ b/presto-kafka/src/test/java/i... | Confused kafka config `kafka.connect-timeout`
Currently, Kafka client doesn't support the connection timeout, there is only one in-progress pull request / issue which was created long time ago (see [KIP-148](https://cwiki.apache.org/confluence/display/KAFKA/KIP-148%3A+Add+a+connect+timeout+for+client) and https://githu... | It would be good to control the timeout.
For now, let's remove the ignored config, it is easy to
re-add it when we actually implement it. | 2020-08-01 09:12:52+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.kafka.TestKafkaConfig.testDefaults', 'io.prestosql.plugin.kafka.TestKafkaConfig.testExplicitPropertyMappings'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Refactoring | false | false | false | true | 2 | 1 | 3 | false | false | ["presto-kafka/src/main/java/io/prestosql/plugin/kafka/KafkaConfig.java->program->class_declaration:KafkaConfig", "presto-kafka/src/main/java/io/prestosql/plugin/kafka/KafkaConfig.java->program->class_declaration:KafkaConfig->method_declaration:Duration_getKafkaConnectTimeout", "presto-kafka/src/main/java/io/prestosql/... |
trinodb/trino | 1,417 | trinodb__trino-1417 | ['1407'] | 016a722127e2c44d22a3aa9b35d56f5714317a90 | diff --git a/presto-parser/src/main/java/io/prestosql/sql/parser/ErrorHandler.java b/presto-parser/src/main/java/io/prestosql/sql/parser/ErrorHandler.java
index 108af47cf2ef..d45929d9b057 100644
--- a/presto-parser/src/main/java/io/prestosql/sql/parser/ErrorHandler.java
+++ b/presto-parser/src/main/java/io/prestosql/sq... | diff --git a/presto-parser/src/test/java/io/prestosql/sql/parser/TestSqlParserErrorHandling.java b/presto-parser/src/test/java/io/prestosql/sql/parser/TestSqlParserErrorHandling.java
index e1de45ee4197..4db7ecb1860f 100644
--- a/presto-parser/src/test/java/io/prestosql/sql/parser/TestSqlParserErrorHandling.java
+++ b/p... | Excessive runtime for parser error reporting
The following query takes over ten minutes to fail with a syntax error:
```sql
SELECT CASE
WHEN orderkey = 1 THEN rand() * rand() * rand() * rand() * rand() * rand() * orderkey
WHEN orderkey = 2 THEN rand() * rand() * rand() * rand() * rand() * rand() * orderkey
WHEN or... | This seems to be caused by 2b33e57518b92d841a48a7d7132f675ee3a847d0 | 2019-08-30 00:11:22+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.sql.parser.TestSqlParserErrorHandling.testStackOverflowExpression', 'io.prestosql.sql.parser.TestSqlParserErrorHandling.testStatement', 'io.prestosql.sql.parser.TestSqlParserErrorHandling.testExpression', 'io.prestosql.sql.parser.TestSqlParserErrorHandling.testParsingExceptionPositionInfo', 'io.prestosql... | ['io.prestosql.sql.parser.TestSqlParserErrorHandling.testStatement', 'io.prestosql.sql.parser.TestSqlParserErrorHandling.testExpression', 'io.prestosql.sql.parser.TestSqlParserErrorHandling.testPossibleExponentialBacktracking'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | false | false | true | 10 | 10 | 20 | false | false | ["presto-parser/src/main/java/io/prestosql/sql/parser/ErrorHandler.java->program->class_declaration:ErrorHandler->class_declaration:Analyzer->method_declaration:Result_process", "presto-parser/src/main/java/io/prestosql/sql/parser/ErrorHandler.java->program->class_declaration:ErrorHandler", "presto-parser/src/main/java... |
trinodb/trino | 2,764 | trinodb__trino-2764 | ['2763'] | 0d67da73beca706c472dbf772d73d378006dc6b1 | diff --git a/presto-main/src/main/java/io/prestosql/execution/UseTask.java b/presto-main/src/main/java/io/prestosql/execution/UseTask.java
index d49678e85b6e..087fd88e3c74 100644
--- a/presto-main/src/main/java/io/prestosql/execution/UseTask.java
+++ b/presto-main/src/main/java/io/prestosql/execution/UseTask.java
@@ -1... | diff --git a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcConnection.java b/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcConnection.java
index d644b18545d3..b05eb052c681 100644
--- a/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJdbcConnection.java
+++ b/presto-jdbc/src/test/java/io/prestosql/jdbc/TestJ... | Validate schema with use command
As discussed with @electrum and @martint on slack.
https://prestosql.slack.com/archives/CFLB9AMBN/p1581114375346700
```
use tpch.foo
```
should fail if the schema does not exist.
Just like
```
use foo.bar
```
fails.
Connectors need to implement checkSchemaExi... | null | 2020-02-07 23:58:56+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.tests.TestDistributedEngineOnlyQueries.testTimeLiterals', 'io.prestosql.jdbc.TestPrestoDatabaseMetaData.testGetCatalogs', 'io.prestosql.jdbc.TestPrestoDatabaseMetaData.testGetAttributes', 'io.prestosql.jdbc.TestPrestoDatabaseMetaData.testGetSuperTypes', 'io.prestosql.jdbc.TestPrestoDatabaseMetaData.testG... | ['io.prestosql.jdbc.TestJdbcConnection.testUse', 'io.prestosql.tests.TestDistributedEngineOnlyQueries.testUse'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["presto-main/src/main/java/io/prestosql/execution/UseTask.java->program->class_declaration:UseTask->method_declaration:execute"] |
trinodb/trino | 1,848 | trinodb__trino-1848 | ['1834'] | 7c090491a3682640af4c932b9cffb813d5ad480a | diff --git a/presto-docs/src/main/sphinx/functions/math.rst b/presto-docs/src/main/sphinx/functions/math.rst
index ae00b4bc85f5..8048cf4e6767 100644
--- a/presto-docs/src/main/sphinx/functions/math.rst
+++ b/presto-docs/src/main/sphinx/functions/math.rst
@@ -135,6 +135,10 @@ Mathematical Functions
Returns a pseu... | diff --git a/presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java b/presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java
index 450c41e6473c..9306874a2a29 100644
--- a/presto-main/src/test/java/io/prestosql/operator/scalar/TestMathFunctions.java
+++ b/presto-main/src/tes... | Add random function taking range min, max
Currently we have `random(n)` (_Returns a pseudo-random number between 0 and n (exclusive)_)
Implement `random(m, n)` returning a pseudo-random number between m and n (exclusive).
| Hello! Can I take this issue?
@victormazevedo Please go ahead :) | 2019-10-24 00:03:48+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | ['io.prestosql.operator.scalar.TestMathFunctions.testBetaCdf', 'io.prestosql.operator.scalar.TestMathFunctions.testInfinity', 'io.prestosql.operator.scalar.TestMathFunctions.testCeil', 'io.prestosql.operator.scalar.TestMathFunctions.testPi', 'io.prestosql.operator.scalar.TestMathFunctions.testFloor', 'io.prestosql.oper... | ['io.prestosql.operator.scalar.TestMathFunctions.testRandom'] | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 4 | 1 | 5 | false | false | ["presto-main/src/main/java/io/prestosql/operator/scalar/MathFunctions.java->program->class_declaration:MathFunctions->method_declaration:randomSmallint", "presto-main/src/main/java/io/prestosql/operator/scalar/MathFunctions.java->program->class_declaration:MathFunctions->method_declaration:randomTinyint", "presto-main... |
trinodb/trino | 1,090 | trinodb__trino-1090 | ['1085'] | 669bcb49800fc4e40fb4db9f9eb180c23f9a6b6a | diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
index 3e2b2352ec2d..e2c9c1e6ffa0 100644
--- a/presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java
+++ b/presto-hive/src/main/java/io/prestosql/plugin/... | diff --git a/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java b/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java
index d258f7055cb3..d12f52fb30e0 100644
--- a/presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java
+... | Allow to set header and footer skip line count for CSV tables
| null | 2019-07-06 14:23:28+00:00 | Java | FROM polybench_java_base
WORKDIR /testbed
COPY . .
ENV JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/
RUN update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java | [] | ['io.prestosql.plugin.hive.TestHiveIntegrationSmokeTest.testRangePredicate', 'io.prestosql.plugin.hive.TestHiveIntegrationSmokeTest.testSelectInformationSchemaTables', 'io.prestosql.plugin.hive.TestHiveIntegrationSmokeTest.testCreateTableOnlyPartitionColumns', 'io.prestosql.plugin.hive.TestHiveIntegrationSmokeTest.test... | [] | find /testbed -path "*/target/surefire-reports/TEST-*.xml" -delete; export JAVA_HOME=/usr/lib/jvm/java-11-amazon-corretto.x86_64/ && update-alternatives --set java /usr/lib/jvm/java-11-amazon-corretto.x86_64/bin/java && sed -i '/<properties>/a \ <air.check.skip-all>true</air.check.skip-all>\n <checkstyle.skip>tru... | Feature | false | false | false | true | 10 | 3 | 13 | false | false | ["presto-hive/src/main/java/io/prestosql/plugin/hive/HiveMetadata.java->program->class_declaration:HiveMetadata->method_declaration:ConnectorTableMetadata_doGetTableMetadata", "presto-hive/src/main/java/io/prestosql/plugin/hive/HiveTableProperties.java->program->class_declaration:HiveTableProperties->method_declaration... |
mrdoob/three.js | 14,566 | mrdoob__three.js-14566 | ['14565'] | 8921bfaee413e809cb2d27f0aec917408d690a0f | diff --git a/docs/api/en/objects/LOD.html b/docs/api/en/objects/LOD.html
--- a/docs/api/en/objects/LOD.html
+++ b/docs/api/en/objects/LOD.html
@@ -70,18 +70,20 @@ <h3>[property:Array levels]</h3>
<p>
An array of [page:Object level] objects<br /><br />
- Each level is an object with two properties:<br />
+ Eac... | diff --git a/test/unit/src/objects/LOD.tests.js b/test/unit/src/objects/LOD.tests.js
--- a/test/unit/src/objects/LOD.tests.js
+++ b/test/unit/src/objects/LOD.tests.js
@@ -73,14 +73,14 @@ export default QUnit.module( 'Objects', () => {
var mid = new Object3D();
var low = new Object3D();
- lod.addLevel( high,... | LOD: Consider adding hysteresis option.
With the LOD systems in Unreal, Unity, and Blender, LODs have a threshold that offsets the distance where the LOD appears from the distance where it disappears, to reduce flickering from small movements (e.g. head movement with roomscale VR). From [Unreal docs](https://docs.unrea... | null | 2018-07-27 04:10:43+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['348 Core > Object3D > copy', '512 Extras > Curves > SplineCurve > getPointAt', '342 Core > Object3D > traverse/traverseVisible/traverseAncestors', '885 Maths > Color > copy', '283 Core > InterleavedBuffer > copyAt', '894 Maths > Color > offsetHSL', '857 Maths > Box3 > expandByScalar', '1232 Maths > Vector2 > min/max/... | ['1402 Objects > LOD > addLevel'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 6 | 1 | 7 | false | false | ["src/objects/LOD.js->program->class_declaration:LOD->method_definition:getObjectForDistance", "src/objects/LOD.js->program->class_declaration:LOD->method_definition:copy", "src/loaders/ObjectLoader.js->program->class_declaration:ObjectLoader->method_definition:parseObject", "src/objects/LOD.js->program->class_declarat... |
mrdoob/three.js | 14,836 | mrdoob__three.js-14836 | ['14834'] | c570b9bd95cf94829715b2cd3a8b128e37768a9c | diff --git a/src/math/Box3.js b/src/math/Box3.js
--- a/src/math/Box3.js
+++ b/src/math/Box3.js
@@ -384,7 +384,7 @@ Object.assign( Box3.prototype, {
}
- return ( min <= plane.constant && max >= plane.constant );
+ return ( min <= - plane.constant && max >= - plane.constant );
},
| diff --git a/test/unit/src/math/Box3.tests.js b/test/unit/src/math/Box3.tests.js
--- a/test/unit/src/math/Box3.tests.js
+++ b/test/unit/src/math/Box3.tests.js
@@ -409,10 +409,22 @@ export default QUnit.module( 'Maths', () => {
var b = new Plane( new Vector3( 0, 1, 0 ), 1 );
var c = new Plane( new Vector3( 0, 1,... | box3.intersectsPlane bug
In the following example, the plane obviously intersects with the box, but the function intersectsPlane returns false.
[example](https://jsfiddle.net/rn6jzdub/4/)
I find that adding two negative sign before both of the plane.constant can fix the bug.
https://github.com/mrdoob/three.js/blob/c... | Good find! Would you like to do a PR with the fix? It would be great if you also adjust the wrong [unit test](https://github.com/mrdoob/three.js/blob/dev/test/unit/src/math/Box3.tests.js#L406).
> Also, I think the definition of the constant of the plane is not distinct, which cause the bug
`three.js` uses [Hessia... | 2018-09-03 10:34:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['1431 Source > Maths > Vector3 > length/lengthSq', '1266 Source > Maths > Sphere > equals', '631 Source > Geometries > PlaneGeometry > Standard geometry tests', '1040 Source > Maths > Color > setStyleRGBAPercentWithSpaces', '553 Source > Extras > Curves > SplineCurve > getTangent', '1238 Source > Maths > Ray > distanc... | ['988 Source > Maths > Box3 > intersectsPlane'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
mrdoob/three.js | 17,649 | mrdoob__three.js-17649 | ['17608'] | c2cf0d97334bc97673053aaa381ae2cc3982a0f6 | diff --git a/docs/api/en/core/BufferGeometry.html b/docs/api/en/core/BufferGeometry.html
--- a/docs/api/en/core/BufferGeometry.html
+++ b/docs/api/en/core/BufferGeometry.html
@@ -144,6 +144,13 @@ <h3>[property:Object morphAttributes]</h3>
Hashmap of [page:BufferAttribute]s holding details of the geometry's [page:Ge... | diff --git a/test/unit/src/core/BufferGeometry.tests.js b/test/unit/src/core/BufferGeometry.tests.js
--- a/test/unit/src/core/BufferGeometry.tests.js
+++ b/test/unit/src/core/BufferGeometry.tests.js
@@ -870,6 +870,7 @@ export default QUnit.module( 'Core', () => {
"name": "attribute1"
} ]
};
+ gold.data... | GLTFLoader: Morph targets only work for matching accessor types
glTF files assume that morph target data is specified as relative adjustments, and three.js assumes that the data in morph target buffers is absolute.
This leads to a few obvious memory/performance caveats - the morph target data needs to be duplicated ... | Here's an example mesh with this problem that works perfectly fine in Babylon.JS but doesn't work in three.js.
[morphbytedeltas.glb.zip](https://github.com/mrdoob/three.js/files/3668257/morphbytedeltas.glb.zip)
> because three.js attempts to reconstruct the absolute position however, attempting to encode Int8 delt... | 2019-10-03 06:01:18+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['966 Source > Maths > Color > toJSON', '1085 Source > Maths > Matrix4 > clone', '943 Source > Maths > Color > clone', '357 Source > Core > Object3D > applyQuaternion', '471 Source > Extras > Curves > CatmullRomCurve3 > getSpacedPoints', '911 Source > Maths > Box3 > isEmpty', '777 Source > Loaders > LoaderUtils > decod... | ['259 Source > Core > BufferGeometry > toJSON'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 9 | 1 | 10 | false | false | ["examples/js/loaders/GLTFLoader.js->program->function_declaration:addMorphTargets", "src/renderers/webgl/WebGLMorphtargets.js->program->function_declaration:WebGLMorphtargets->function_declaration:update", "examples/js/loaders/GLTFLoader.js->program->function_declaration:cloneBufferAttribute", "examples/jsm/exporters/... |
mrdoob/three.js | 17,894 | mrdoob__three.js-17894 | ['17812'] | 47a438f14fcd878758c319773d76c4dbd55fbe4a | diff --git a/src/objects/LOD.d.ts b/src/objects/LOD.d.ts
--- a/src/objects/LOD.d.ts
+++ b/src/objects/LOD.d.ts
@@ -10,9 +10,10 @@ export class LOD extends Object3D {
type: 'LOD';
levels: { distance: number; object: Object3D }[];
+ autoUpdate: boolean;
addLevel( object: Object3D, distance?: number ): this;
- g... | diff --git a/test/unit/src/objects/LOD.tests.js b/test/unit/src/objects/LOD.tests.js
--- a/test/unit/src/objects/LOD.tests.js
+++ b/test/unit/src/objects/LOD.tests.js
@@ -3,6 +3,8 @@
*/
/* global QUnit */
+import { Object3D } from '../../../../src/core/Object3D';
+import { Raycaster } from '../../../../src/core/Ra... | Exception if LOD has no levels defined
##### Description of the problem
This is a very simple problem in the code of `getObjectForDistance` in `LOD.js`:
```
getObjectForDistance: function ( distance ) {
var levels = this.levels;
for ( var i = 1, l = levels.length; i < l; i ++ ) {
if ( distance < levels[ i... | In this case, it's also necessary to change `LOD.raycast()`. Even with your proposed change, the method would throw an exception because of the following line.
```js
this.getObjectForDistance( distance ).raycast( raycaster, intersects );
```
If no levels are defined, `getObjectForDistance()` would return `undefined... | 2019-11-08 14:13:48+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['966 Source > Maths > Color > toJSON', '1085 Source > Maths > Matrix4 > clone', '943 Source > Maths > Color > clone', '357 Source > Core > Object3D > applyQuaternion', '471 Source > Extras > Curves > CatmullRomCurve3 > getSpacedPoints', '911 Source > Maths > Box3 > isEmpty', '777 Source > Loaders > LoaderUtils > decod... | ['1451 Source > Objects > LOD > copy', '1453 Source > Objects > LOD > getObjectForDistance', '1454 Source > Objects > LOD > raycast'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | false | true | false | 0 | 1 | 1 | false | true | ["src/objects/LOD.d.ts->program->class_declaration:LOD"] |
mrdoob/three.js | 17,933 | mrdoob__three.js-17933 | ['17920'] | 92f08b4cdece761ba27abd87f33e624ecb16c284 | diff --git a/src/loaders/LoadingManager.js b/src/loaders/LoadingManager.js
--- a/src/loaders/LoadingManager.js
+++ b/src/loaders/LoadingManager.js
@@ -121,6 +121,8 @@ function LoadingManager( onLoad, onProgress, onError ) {
var regex = handlers[ i ];
var loader = handlers[ i + 1 ];
+ if ( regex.global ) reg... | diff --git a/test/unit/src/loaders/LoadingManager.tests.js b/test/unit/src/loaders/LoadingManager.tests.js
--- a/test/unit/src/loaders/LoadingManager.tests.js
+++ b/test/unit/src/loaders/LoadingManager.tests.js
@@ -4,6 +4,7 @@
/* global QUnit */
import { LoadingManager } from '../../../../src/loaders/LoadingManager... | LoadingManager.getHandler does not work half the time if a regex with g flag is passed
If adding a handler with a regex that has the `g` flag, the `regex.test` in `getHandler` will return null every other time.
I think `string.match` should be used rather than `regex.test` to avoid any side effect like this
| Could you share an example to reproduce this issue?
Here you go @donmccurdy
https://jsfiddle.net/qkwx4Lg1/2
so basically this:
mozdev says:
> As with exec() (or in combination ... | 2019-11-14 19:29:58+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['357 Source > Core > Object3D > applyQuaternion', '1093 Source > Maths > Matrix4 > premultiply', '471 Source > Extras > Curves > CatmullRomCurve3 > getSpacedPoints', '1116 Source > Maths > Plane > Instancing', '1172 Source > Maths > Ray > closestPointToPoint', '777 Source > Loaders > LoaderUtils > decodeText', '1186 S... | ['787 Source > Loaders > LoadingManager > getHandler'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/loaders/LoadingManager.js->program->function_declaration:LoadingManager"] |
mrdoob/three.js | 18,648 | mrdoob__three.js-18648 | ['18590'] | cceffcbec987ba640b98285503e1267336626f22 | diff --git a/docs/api/en/core/Raycaster.html b/docs/api/en/core/Raycaster.html
--- a/docs/api/en/core/Raycaster.html
+++ b/docs/api/en/core/Raycaster.html
@@ -93,11 +93,6 @@ <h3>[property:float far]</h3>
This value shouldn't be negative and should be larger than the near property.
</p>
- <h3>[property:float li... | diff --git a/test/unit/src/core/Raycaster.tests.js b/test/unit/src/core/Raycaster.tests.js
--- a/test/unit/src/core/Raycaster.tests.js
+++ b/test/unit/src/core/Raycaster.tests.js
@@ -7,6 +7,9 @@ import { Raycaster } from '../../../../src/core/Raycaster';
import { Vector3 } from '../../../../src/math/Vector3';
import ... | Inconsistent raycast precision API
##### Description of the problem
Both `Points` and `Line` implement a `raycast()` function/method. They both use a threshold/precision:
https://github.com/mrdoob/three.js/blob/138d25dbd138f9feedbb20ade26f104155a50d8f/src/objects/Points.js#L37-L59
https://github.com/mrdoob/thr... | Related #5366.
Just to be clear, I am not suggesting changing the units of the raycaster precision. I think world units are just fine. :blush:
Agreed, a common approach for `Points` and `Lines` is desirable. I think I vote for enhancing `Raycaster.params`, too. And deprecating `Raycaster.linePrecision`.
So will the con... | 2020-02-17 00:53:10+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['1111 Source > Maths > Plane > clone', '1355 Source > Maths > Vector3 > multiply/divide', '1133 Source > Maths > Quaternion > clone', '1280 Source > Maths > Vector2 > multiply/divide', '357 Source > Core > Object3D > applyQuaternion', '969 Source > Maths > Color > setStyleHSLRed', '1272 Source > Maths > Vector2 > mult... | ['394 Source > Core > Raycaster > Line intersection threshold'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Refactoring | false | false | false | true | 1 | 1 | 2 | false | false | ["src/core/Raycaster.js->program->function_declaration:Raycaster", "src/core/Raycaster.d.ts->program->class_declaration:Raycaster"] |
mrdoob/three.js | 18,885 | mrdoob__three.js-18885 | ['17926'] | e3d60b17c0497a08ecb166eae799eb5cf6d9e7f5 | diff --git a/docs/api/en/math/Matrix3.html b/docs/api/en/math/Matrix3.html
--- a/docs/api/en/math/Matrix3.html
+++ b/docs/api/en/math/Matrix3.html
@@ -106,15 +106,14 @@ <h3>[method:this fromArray]( [param:Array array], [param:Integer offset] )</h3>
[link:https://en.wikipedia.org/wiki/Row-_and_column-major_order#Colu... | diff --git a/test/unit/src/math/Matrix3.tests.js b/test/unit/src/math/Matrix3.tests.js
--- a/test/unit/src/math/Matrix3.tests.js
+++ b/test/unit/src/math/Matrix3.tests.js
@@ -6,7 +6,6 @@
import { Matrix3 } from '../../../../src/math/Matrix3';
import { Matrix4 } from '../../../../src/math/Matrix4';
-import { Float32... | Cleaner handling of 0 scale
##### Description of the problem
Whenever an object is scaled to 0 (scale.set(0,0,0)) or a camera and target are at position (0, 0, 0), ThreeJS stops rendering the objects and fills the console with errors:
THREE.Matrix3: .getInverse() can't invert matrix, determinant is 0
I feel li... | When this issue was last discussed in 2012, I think that negative scales were not supported.
Now that we support both positive and negative scale values, this seems like a more reasonable request. Otherwise I don't think there's any way for someone to tween from negative to positive scale.
> I don't think there's ... | 2020-03-12 20:34:41+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && sed -i 's/failonlyreporter/tap/g' package.json
RUN . $NVM_DIR/nvm.sh && nvm al... | ['1111 Source > Maths > Plane > clone', '1355 Source > Maths > Vector3 > multiply/divide', '1133 Source > Maths > Quaternion > clone', '1280 Source > Maths > Vector2 > multiply/divide', '357 Source > Core > Object3D > applyQuaternion', '969 Source > Maths > Color > setStyleHSLRed', '1272 Source > Maths > Vector2 > mult... | ['1089 Source > Maths > Matrix4 > getInverse', '1061 Source > Maths > Matrix3 > getInverse'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | false | true | false | 0 | 1 | 1 | false | true | ["src/math/Matrix4.d.ts->program->class_declaration:Matrix4"] |
mrdoob/three.js | 20,478 | mrdoob__three.js-20478 | ['20414'] | b47af3a31dd770a731563476089b97852a1117cb | diff --git a/docs/api/en/core/Object3D.html b/docs/api/en/core/Object3D.html
--- a/docs/api/en/core/Object3D.html
+++ b/docs/api/en/core/Object3D.html
@@ -314,6 +314,11 @@ <h3>[method:this remove]( [param:Object3D object], ... )</h3>
Removes *object* as child of this object. An arbitrary number of objects may be rem... | diff --git a/test/unit/src/core/Object3D.tests.js b/test/unit/src/core/Object3D.tests.js
--- a/test/unit/src/core/Object3D.tests.js
+++ b/test/unit/src/core/Object3D.tests.js
@@ -296,7 +296,7 @@ export default QUnit.module( 'Core', () => {
} );
- QUnit.test( "add/remove", ( assert ) => {
+ QUnit.test( "add/rem... | Object3D: Add removeAll or clear.
I'd like to have removeAll or clear method in Object3D.
```
remove: function ( object ) {
if ( arguments.length > 1 ) {
for ( let i = 0; i < arguments.length; i ++ ) {
this.remove( arguments[ i ] );
}
return this;
}
const index = this.childr... | Sounds good to me.
I thing I would prefer something like this:
```js
clear: function () {
while ( this.children.length > 0 ) {
const object = this.children.pop();
object.parent = null;
object.dispatchEvent( _removedEvent );
}
return this;
}
```
`this.children.pop` spends more time than... | 2020-10-08 12:18:34+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['1405 Source > Maths > Vector4 > toArray', '995 Source > Maths > Euler > set/get properties, check callbacks', '1176 Source > Maths > Sphere > Instancing', '1361 Source > Maths > Vector4 > Instancing', '1050 Source > Maths > Matrix3 > isMatrix3', '471 Source > Extras > Curves > CatmullRomCurve3 > getSpacedPoints', '13... | ['373 Source > Core > Object3D > add/remove/removeAll'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | true | false | 0 | 1 | 1 | false | true | ["src/core/Object3D.d.ts->program->class_declaration:Object3D"] |
mrdoob/three.js | 20,991 | mrdoob__three.js-20991 | ['20921'] | 4ccb9d223786a7f1e58eb563dfc4bfd672b737db | diff --git a/docs/api/en/math/Matrix3.html b/docs/api/en/math/Matrix3.html
--- a/docs/api/en/math/Matrix3.html
+++ b/docs/api/en/math/Matrix3.html
@@ -159,7 +159,7 @@ <h3>[method:this premultiply]( [param:Matrix3 m] )</h3>
<p>Pre-multiplies this matrix by [page:Matrix3 m].</p>
<h3>[method:this setFromMatrix4]( ... | diff --git a/test/unit/src/math/Matrix4.tests.js b/test/unit/src/math/Matrix4.tests.js
--- a/test/unit/src/math/Matrix4.tests.js
+++ b/test/unit/src/math/Matrix4.tests.js
@@ -1,5 +1,6 @@
/* global QUnit */
+import { Matrix3 } from '../../../../src/math/Matrix3';
import { Matrix4 } from '../../../../src/math/Matrix4... | Be able to use rotation matrix of 3x3 : THREE.Quaternion().setFromRotationMatrix(matrix3)
Currently `THREE.Quaternion().setFromRotationMatrix(matrix4)` uses a `THREE.Matrix4`
As a rotation can be stored in a `Matrix3`, it could be great to be able to use also directly a `THREE.Matrix3`
Currently I convert myself th... | > Also, this not clear, why currently the expected matrix4 is transposed.
This is outlined in [Matrix3 docs](https://threejs.org/docs/#api/en/math/Matrix3) in the "A Note on Row-Major and Column-Major Ordering" section (And on the Matrix4 docs page, too).
A Matrix4.setFromMatrix3 equivalent for [Matrix3.setFromMa... | 2021-01-02 18:27:49+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['1127 Source > Maths > Quaternion > slerpFlat', '1266 Source > Maths > Vector2 > setLength', '969 Source > Maths > Color > setStyleHSLRed', '235 Source > Core > BufferGeometry > setIndex/getIndex', '553 Source > Extras > Curves > SplineCurve > getTangent', '534 Source > Extras > Curves > QuadraticBezierCurve > getSpac... | ['1078 Source > Maths > Matrix4 > setFromMatrix4'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 1 | 1 | 2 | false | false | ["src/math/Matrix4.js->program->class_declaration:Matrix4->method_definition:setFromMatrix3", "src/math/Matrix4.js->program->class_declaration:Matrix4"] |
mrdoob/three.js | 21,532 | mrdoob__three.js-21532 | ['21498'] | ff75ee91591e6c977cf0ceb716e73adb34c090f2 | diff --git a/docs/api/en/math/Quaternion.html b/docs/api/en/math/Quaternion.html
--- a/docs/api/en/math/Quaternion.html
+++ b/docs/api/en/math/Quaternion.html
@@ -163,6 +163,9 @@ <h3>[method:Quaternion slerp]( [param:Quaternion qb], [param:Float t] )</h3>
</code>
</p>
+ <h3>[method:this slerpQuaternions]( [pa... | diff --git a/test/unit/src/math/Quaternion.tests.js b/test/unit/src/math/Quaternion.tests.js
--- a/test/unit/src/math/Quaternion.tests.js
+++ b/test/unit/src/math/Quaternion.tests.js
@@ -657,6 +657,22 @@ export default QUnit.module( 'Maths', () => {
} );
+ QUnit.test( "slerpQuaternions", ( assert ) => {
+
+ v... | Feature: Quaternion.slerpQuaternions()
It's already possible to easily interpolate between two quaternions by using the static helper, but the Vector classes already implement a .lerpVectors, would it make sense to also have the same API for quaternions?
```js
const q = new Quaternion()
q.slerpQuaternions(quatA, q... | I'm fine with such a method. It should be:
```js
slerpQuaternions( qa, qb, t ) {
this.copy( qa ).slerp( qb, t );
}
```
I'll PR it later today 👍
Yes, and I would suggest having it replace the static method:
```js
static slerp( qa, qb, qm, t ) {
return qm.copy( qa ).slerp( qb, t );
}
```
Retai... | 2021-03-27 09:07:34+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['303 Source > Core > Layers > toggle', '328 Source > Core > Object3D > localToWorld', '877 Source > Maths > Box3 > intersect', '901 Source > Maths > Color > getStyle', '846 Source > Maths > Box2 > union', '965 Source > Maths > Frustum > setFromProjectionMatrix/makePerspective/containsPoint', '828 Source > Maths > Box2... | ['1109 Source > Maths > Quaternion > slerpQuaternions'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 2 | 1 | 3 | false | false | ["src/math/Quaternion.js->program->class_declaration:Quaternion", "src/math/Quaternion.js->program->class_declaration:Quaternion->method_definition:slerp", "src/math/Quaternion.js->program->class_declaration:Quaternion->method_definition:slerpQuaternions"] |
mrdoob/three.js | 21,826 | mrdoob__three.js-21826 | ['21714'] | c4002a6004dd88070b8dac7740020c9f169f27e9 | diff --git a/docs/api/en/core/Object3D.html b/docs/api/en/core/Object3D.html
--- a/docs/api/en/core/Object3D.html
+++ b/docs/api/en/core/Object3D.html
@@ -325,6 +325,11 @@ <h3>[method:this remove]( [param:Object3D object], ... )</h3>
Removes *object* as child of this object. An arbitrary number of objects may be rem... | diff --git a/test/unit/src/core/Object3D.tests.js b/test/unit/src/core/Object3D.tests.js
--- a/test/unit/src/core/Object3D.tests.js
+++ b/test/unit/src/core/Object3D.tests.js
@@ -440,6 +440,12 @@ export default QUnit.module( 'Core', () => {
assert.strictEqual( child1.parent, null, "First child has no parent" );
... | can we have Object3D.remove() with no arguments remove an object itself?
so that we can write `light.remove();` instead of `light.parent.remove(light);` ?
right now .remove() does not seem to be doing anything so there will be no conflict.
| I think this is a good feature request. I've often encountered issues where this semantic would be convenient. The method would then behave like [the remove() method of DOM elements](https://www.w3schools.com/jsref/met_element_remove.asp) if invocated with no parameters.
>can we have Object3D.remove() with no arguments... | 2021-05-13 08:52:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['303 Source > Core > Layers > toggle', '328 Source > Core > Object3D > localToWorld', '877 Source > Maths > Box3 > intersect', '901 Source > Maths > Color > getStyle', '1049 Source > Maths > Matrix4 > setPosition', '846 Source > Maths > Box2 > union', '1364 Source > Maths > Vector4 > normalize', '1127 Source > Maths >... | ['331 Source > Core > Object3D > add/remove/clear'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 1 | 1 | 2 | false | false | ["src/core/Object3D.js->program->class_declaration:Object3D", "src/core/Object3D.js->program->class_declaration:Object3D->method_definition:removeFromParent"] |
mrdoob/three.js | 22,404 | mrdoob__three.js-22404 | ['22337'] | a67f135409f902619005e0dd8e015ccb374b8ae1 | diff --git a/docs/api/en/math/Triangle.html b/docs/api/en/math/Triangle.html
--- a/docs/api/en/math/Triangle.html
+++ b/docs/api/en/math/Triangle.html
@@ -126,6 +126,16 @@ <h3>[method:Triangle set]( [param:Vector3 a], [param:Vector3 b], [param:Vector3
Please note that this method only copies the values from the give... | diff --git a/test/unit/src/math/Triangle.tests.js b/test/unit/src/math/Triangle.tests.js
--- a/test/unit/src/math/Triangle.tests.js
+++ b/test/unit/src/math/Triangle.tests.js
@@ -1,5 +1,6 @@
/* global QUnit */
+import { BufferAttribute } from '../../../../src/core/BufferAttribute';
import { Triangle } from '../../.... | Triangle.setFromPointsAndIndices buffer attribute version?
I just noticed that while geometry.vertices is gone, triangle.setFromPointsAndIndices is still there, and only used in unit test. It seems that accepting geometry.attributes.position would make more sense now, no?
| The method was not necessarily intended to directly work on `geometry.vertices`. Most math methods assume points are defined as `Vector3`s.
It is super obvious that the method was intended to work on clicked face, but you can always ask @bhouston who had [added it](https://github.com/mrdoob/three.js/commit/c5d38e8993a5... | 2021-08-24 10:41:08+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['241 Source > Core > BufferGeometry > scale', '303 Source > Core > Layers > toggle', '328 Source > Core > Object3D > localToWorld', '877 Source > Maths > Box3 > intersect', '901 Source > Maths > Color > getStyle', '846 Source > Maths > Box2 > union', '1364 Source > Maths > Vector4 > normalize', '828 Source > Maths > B... | ['1171 Source > Maths > Triangle > setFromAttributeAndIndices'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 1 | 1 | 2 | false | false | ["src/math/Triangle.js->program->class_declaration:Triangle", "src/math/Triangle.js->program->class_declaration:Triangle->method_definition:setFromAttributeAndIndices"] |
mrdoob/three.js | 22,566 | mrdoob__three.js-22566 | ['8522'] | 7f6a0990feec2946225147ab2a4fbcaf69dcb359 | diff --git a/src/core/BufferGeometry.js b/src/core/BufferGeometry.js
--- a/src/core/BufferGeometry.js
+++ b/src/core/BufferGeometry.js
@@ -1004,31 +1004,7 @@ class BufferGeometry extends EventDispatcher {
clone() {
- /*
- // Handle primitives
-
- const parameters = this.parameters;
-
- if ( parameters !== ... | diff --git a/test/unit/utils/qunit-utils.js b/test/unit/utils/qunit-utils.js
--- a/test/unit/utils/qunit-utils.js
+++ b/test/unit/utils/qunit-utils.js
@@ -83,12 +83,10 @@ function checkGeometryClone( geom ) {
QUnit.assert.notEqual( copy.uuid, geom.uuid, "clone uuid should differ from original" );
QUnit.assert.notEq... | Clone cylinderGeometry Creates Geometry
##### Description of the problem
When cloning a cylinderGeometry the clone is a geometry not a cylinderGeometry.
simple fiddle,check the console: http://jsfiddle.net/momve8hk/
Tested in r72 and i get a cylinderGeometry.
...
##### Three.js version
- [x] r75
| /ping @Mugen87
I ended up just making new cylinder geometries from the parameters object. Seems to work pretty well.
I think this [line of code](https://github.com/mrdoob/three.js/blob/7e0a78beb9317e580d7fa4da9b5b12be051c6feb/src/core/Geometry.js#L1151) causes the behavior. The implementation of the `Geometry .clo... | 2021-09-22 08:38:30+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['241 Source > Core > BufferGeometry > scale', '303 Source > Core > Layers > toggle', '426 Source > Extras > Curves > CatmullRomCurve3 > computeFrenetFrames', '901 Source > Maths > Color > toArray', '328 Source > Core > Object3D > localToWorld', '686 Source > Loaders > BufferGeometryLoader > parser - attributes - circl... | ['526 Source > Geometries > CylinderGeometry > Standard geometry tests', '573 Source > Geometries > TorusBufferGeometry > Standard geometry tests', '546 Source > Geometries > IcosahedronGeometry > Standard geometry tests', '520 Source > Geometries > CircleGeometry > Standard geometry tests', '576 Source > Geometries > ... | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["src/core/BufferGeometry.js->program->class_declaration:BufferGeometry->method_definition:clone", "src/core/BufferGeometry.js->program->class_declaration:BufferGeometry->method_definition:copy", "src/geometries/PolyhedronGeometry.js->program->class_declaration:PolyhedronGeometry->method_definition:constructor"] |
mrdoob/three.js | 22,981 | mrdoob__three.js-22981 | ['22980'] | 8abf54b18078206ab4aac148ed956456d0d6bff7 | diff --git a/src/math/Sphere.js b/src/math/Sphere.js
--- a/src/math/Sphere.js
+++ b/src/math/Sphere.js
@@ -193,7 +193,16 @@ class Sphere {
// 1) Enclose the farthest point on the other sphere into this sphere.
// 2) Enclose the opposite point of the farthest point into this sphere.
- _toFarthestPoint.subVector... | diff --git a/test/unit/src/math/Sphere.tests.js b/test/unit/src/math/Sphere.tests.js
--- a/test/unit/src/math/Sphere.tests.js
+++ b/test/unit/src/math/Sphere.tests.js
@@ -279,6 +279,16 @@ export default QUnit.module( 'Maths', () => {
assert.ok( c.center.equals( new Vector3( 1, 0, 0 ) ), 'Passed!' );
assert.ok( ... | Sphere.union() produces incorrect results if both spheres have the same center
<!-- Ignoring this template may result in your bug report getting deleted -->
**Describe the bug**
When using Sphere.union() the original sphere is not expanded to enclose the given sphere (even if the given one is bigger) if both of t... | null | 2021-12-08 13:09:13+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['241 Source > Core > BufferGeometry > scale', '303 Source > Core > Layers > toggle', '512 Source > Extras > Curves > SplineCurve > getSpacedPoints', '863 Source > Maths > Box3 > union', '1060 Source > Maths > Plane > distanceToPoint', '850 Source > Maths > Box3 > expandByScalar', '937 Source > Maths > Euler > reorder'... | ['1142 Source > Maths > Sphere > union'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/math/Sphere.js->program->class_declaration:Sphere->method_definition:union"] |
mrdoob/three.js | 23,596 | mrdoob__three.js-23596 | ['23563'] | 30f34a310375c2a7ad58effa5474cdbf5375c595 | diff --git a/docs/api/en/extras/DataUtils.html b/docs/api/en/extras/DataUtils.html
--- a/docs/api/en/extras/DataUtils.html
+++ b/docs/api/en/extras/DataUtils.html
@@ -19,7 +19,14 @@ <h3>[method:Number toHalfFloat]( [param:Number val] )</h3>
<p>
val -- A single precision floating point value.<br /><br />
- Retu... | diff --git a/test/unit/src/extras/DataUtils.tests.js b/test/unit/src/extras/DataUtils.tests.js
new file mode 100644
--- /dev/null
+++ b/test/unit/src/extras/DataUtils.tests.js
@@ -0,0 +1,37 @@
+/* global QUnit */
+
+import { DataUtils } from '../../../../src/extras/DataUtils.js';
+
+export default QUnit.module( 'Extras... | Feature request: Add `.fromHalfFloat()` to DataUtils.
`DataUtils` already has `.toHalfFloat( val )`.
`DataUtils.fromHalfFloat( half )` would be useful for evaluating the dynamic range of HDR textures in .exr format, for example.
| null | 2022-02-26 10:19:20+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['348 Core > Object3D > copy', '512 Extras > Curves > SplineCurve > getPointAt', '342 Core > Object3D > traverse/traverseVisible/traverseAncestors', '885 Maths > Color > copy', '283 Core > InterleavedBuffer > copyAt', '894 Maths > Color > offsetHSL', '857 Maths > Box3 > expandByScalar', '1232 Maths > Vector2 > min/max/... | ['359 Extras > DataUtils > toHalfFloat', '360 Extras > DataUtils > fromHalfFloat'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 2 | 1 | 3 | false | false | ["src/extras/DataUtils.js->program->class_declaration:DataUtils->method_definition:toHalfFloat", "src/extras/DataUtils.js->program->class_declaration:DataUtils", "src/extras/DataUtils.js->program->class_declaration:DataUtils->method_definition:fromHalfFloat"] |
mrdoob/three.js | 23,796 | mrdoob__three.js-23796 | ['23793'] | 1e0cdd9c6304dac238e9d6891652c1ce81f38580 | diff --git a/docs/api/en/math/Color.html b/docs/api/en/math/Color.html
--- a/docs/api/en/math/Color.html
+++ b/docs/api/en/math/Color.html
@@ -13,6 +13,10 @@ <h1>[name]</h1>
Class representing a color.
</p>
+ <p>
+ Iterating through a [name] instance will yield its components (r, g, b) in the corresponding or... | diff --git a/test/unit/src/math/Color.tests.js b/test/unit/src/math/Color.tests.js
--- a/test/unit/src/math/Color.tests.js
+++ b/test/unit/src/math/Color.tests.js
@@ -651,6 +651,16 @@ export default QUnit.module( 'Maths', () => {
} );
+ QUnit.test( 'iterable', ( assert ) => {
+
+ var c = new Color( 0.5, 0.75,... | RFC: Making Euler, Color, Quaternions iterable - and consequently spreadable - like Vector*
Vectors are iterable, so they can be spread to an array like `[...vector]`. The same isn't true for Euler, and users ** cough cough me right now ** might expect consistent behaviour.
I was surprised to see this missing, so I'... | `Color` is also missing an iterator.
@LeviPesin also Quaternion. Let me report all of those in the initial comment, it's a good idea | 2022-03-26 08:39:02+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['348 Core > Object3D > copy', '512 Extras > Curves > SplineCurve > getPointAt', '342 Core > Object3D > traverse/traverseVisible/traverseAncestors', '885 Maths > Color > copy', '1034 Maths > Matrix4 > lookAt', '283 Core > InterleavedBuffer > copyAt', '894 Maths > Color > offsetHSL', '1312 Maths > Vector3 > setComponent... | ['951 Maths > Euler > iterable', '1111 Maths > Quaternion > iterable', '927 Maths > Color > iterable'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Feature | false | false | false | true | 3 | 3 | 6 | false | false | ["src/math/Quaternion.js->program->class_declaration:Quaternion", "src/math/Quaternion.js->program->class_declaration:Quaternion->method_definition:[ Symbol.iterator ]", "src/math/Color.js->program->class_declaration:Color", "src/math/Euler.js->program->class_declaration:Euler->method_definition:[ Symbol.iterator ]", "... |
mrdoob/three.js | 24,219 | mrdoob__three.js-24219 | ['24167'] | 31730c1e8825c4318009fe5eaa9ce8bf9d49cfb2 | diff --git a/src/math/Matrix3.js b/src/math/Matrix3.js
--- a/src/math/Matrix3.js
+++ b/src/math/Matrix3.js
@@ -2,7 +2,7 @@ class Matrix3 {
constructor() {
- this.isMatrix3 = true;
+ Matrix3.prototype.isMatrix3 = true;
this.elements = [
diff --git a/src/math/Matrix4.js b/src/math/Matrix4.js
--- a/src/math... | diff --git a/test/unit/src/core/Object3D.tests.js b/test/unit/src/core/Object3D.tests.js
--- a/test/unit/src/core/Object3D.tests.js
+++ b/test/unit/src/core/Object3D.tests.js
@@ -301,9 +301,11 @@ export default QUnit.module( 'Core', () => {
obj.translateOnAxis( new Vector3( 0, 1, 0 ), 1.23 );
obj.translateOnAxi... | isVector3 is present when serializing Vector3
<!-- Ignoring this template may result in your bug report getting deleted -->
**Describe the bug**
A clear and concise description of what the bug is. Before submitting, please remove unnecessary sections.
since r141, when serializing Vector3 class using JSON.stri... | This is duplicate of #24093.
Serializing math objects should not be done via `JSON.stringify()`. Please use `toArray()` and `fromArray()` interface.
Well, that will require a LOT of change in my code. a LOT.
And I'm still not sure why you need a boolean to indicate if it is a Vector3 or not. This seems really real... | 2022-06-09 15:05:26+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['348 Core > Object3D > copy', '512 Extras > Curves > SplineCurve > getPointAt', '342 Core > Object3D > traverse/traverseVisible/traverseAncestors', '1154 Maths > Spherical > makeSafe', '885 Maths > Color > copy', '283 Core > InterleavedBuffer > copyAt', '1359 Maths > Vector4 > setLength', '894 Maths > Color > offsetHS... | ['326 Core > Object3D > translateOnAxis'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["src/math/Matrix4.js->program->class_declaration:Matrix4->method_definition:constructor", "src/math/Vector2.js->program->class_declaration:Vector2->method_definition:constructor", "src/math/Vector3.js->program->class_declaration:Vector3->method_definition:constructor", "src/math/Matrix3.js->program->class_declaration:... |
mrdoob/three.js | 24,461 | mrdoob__three.js-24461 | ['24441'] | 9e5512f067e3a0de8d4069217d20903c1725edf7 | diff --git a/src/math/Color.js b/src/math/Color.js
--- a/src/math/Color.js
+++ b/src/math/Color.js
@@ -222,12 +222,12 @@ class Color {
case 'hsl':
case 'hsla':
- if ( color = /^\s*(\d*\.?\d+)\s*,\s*(\d+)\%\s*,\s*(\d+)\%\s*(?:,\s*(\d*\.?\d+)\s*)?$/.exec( components ) ) {
+ if ( color = /^\s*(\d*\.?\d... | diff --git a/test/unit/src/math/Color.tests.js b/test/unit/src/math/Color.tests.js
--- a/test/unit/src/math/Color.tests.js
+++ b/test/unit/src/math/Color.tests.js
@@ -611,6 +611,30 @@ export default QUnit.module( 'Maths', () => {
} );
+ QUnit.test( 'setStyleHSLRedWithDecimals', ( assert ) => {
+
+ var c = new... | Color: Support HSL percentage values with decimals.
**Describe the bug**
Using decimal values for `saturation` or `lightness` in an HSL colors lead to `Unknown color` warning
**To Reproduce**
see live example
***Code***
```js
new THREE.Color('hsl(209, 95.0%, 90.1%)')
```
***Live example***
https:... | I have always thought percentage values for saturation and lightness are integers. If this is not exactly defined in the CSS spec, I vote to not change the current implementation.
If I’m reading the spec correctly, `percent` contains `number` which supports decimal values: https://www.w3.org/TR/css-values-4/#number-val... | 2022-08-07 08:05:56+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && rm -rf node_modules && if [ -f yarn.lock ]; then yarn install; else npm install --force; fi && npm i --prefix test && sed -i 's/failonlyreporter/tap/g' package.json test/pac... | ['1026 Maths > Matrix4 > identity', '483 Extras > Curves > LineCurve3 > computeFrenetFrames', '957 Maths > Frustum > clone', '823 Maths > Box2 > copy', '81 Animation > KeyframeTrack > optimize', '1491 Renderers > WebGL > WebGLExtensions > has', '233 Core > BufferGeometry > setIndex/getIndex', '1159 Maths > Triangle > I... | ['923 Maths > Color > setStyleHSLRedWithDecimals', '924 Maths > Color > setStyleHSLARedWithDecimals'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/math/Color.js->program->class_declaration:Color->method_definition:setStyle"] |
sveltejs/svelte | 416 | sveltejs__svelte-416 | ['413'] | b9d3c235e79a4426c4eaea6c4029139737bdc718 | diff --git a/src/generators/dom/index.js b/src/generators/dom/index.js
--- a/src/generators/dom/index.js
+++ b/src/generators/dom/index.js
@@ -246,22 +246,23 @@ export default function dom ( parsed, source, options ) {
if ( computations.length ) {
const builder = new CodeBuilder();
+ const differs = generator.h... | diff --git a/test/generator/samples/computed-values-function-dependency/_config.js b/test/generator/samples/computed-values-function-dependency/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/computed-values-function-dependency/_config.js
@@ -0,0 +1,10 @@
+export default {
+ html: '<p>2</p>',... | Functions should be treated as objects for purposes of updating computations
[This example](https://svelte.technology/repl?version=1.13.1&gist=4a539c95737f43bdccd74ab5ebf8d52d) shows the bug (which I did just encounter in a real application, as bizarre as the example looks) — computed values are recomputed if one or mo... | In that example, isn't `getFoo` arguably no longer a pure function? That's not to say there's not still some bug here, or that there's not some other less insane-looking way to reproduce this.
On the other hand I guess in this case burdening everyone with an extra `typeof` to handle this case isn't really all that m... | 2017-03-28 16:31:33+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ignores-irrelevant-changes'... | ['generate shared helpers computed-values-function-dependency', 'generate inline helpers computed-values-function-dependency'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/generators/dom/index.js->program->function_declaration:dom", "src/shared/index.js->program->function_declaration:differs"] |
sveltejs/svelte | 426 | sveltejs__svelte-426 | ['424'] | 38ee4f15cf2bacb4f6c16528442f7842c2791b9c | diff --git a/src/parse/read/expression.js b/src/parse/read/expression.js
--- a/src/parse/read/expression.js
+++ b/src/parse/read/expression.js
@@ -3,16 +3,6 @@ import { parseExpressionAt } from 'acorn';
export default function readExpression ( parser ) {
const start = parser.index;
- const name = parser.readUntil(... | diff --git a/test/generator/samples/attribute-prefer-expression/_config.js b/test/generator/samples/attribute-prefer-expression/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/attribute-prefer-expression/_config.js
@@ -0,0 +1,19 @@
+export default {
+ 'skip-ssr': true,
+
+ data: {
+ foo: fal... | `true` and `false` are treated as names
[REPL](https://svelte.technology/repl?version=1.13.2&gist=d13db0a0195744426e7613f99919a106) — this template...
```html
<label>
<input type='radio' bind:group='foo' value='{{false}}'> input
</label>
<label>
<input type='radio' bind:group='foo' value='{{true}}'> outpu... | Note: you can workaround this by adding `'false': false, 'true': true` to your data....
Yeah this is definitely from #385. If we want to keep that behavior, instead of having special cases for certain names (`true`, `false, etc), maybe we could first try parsing, and then if that failed and we were a single all-lowerca... | 2017-03-29 20:58:24+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ignores-irrelevant-changes'... | ['generate shared helpers attribute-prefer-expression', 'generate inline helpers attribute-prefer-expression'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/parse/read/expression.js->program->function_declaration:readExpression"] |
sveltejs/svelte | 427 | sveltejs__svelte-427 | ['423'] | 38ee4f15cf2bacb4f6c16528442f7842c2791b9c | diff --git a/src/generators/dom/visitors/attributes/lookup.js b/src/generators/dom/visitors/attributes/lookup.js
--- a/src/generators/dom/visitors/attributes/lookup.js
+++ b/src/generators/dom/visitors/attributes/lookup.js
@@ -109,7 +109,7 @@ const lookup = {
title: {},
type: { appliesTo: [ 'button', 'input', 'comm... | diff --git a/test/generator/samples/select-one-way-bind/_config.js b/test/generator/samples/select-one-way-bind/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/select-one-way-bind/_config.js
@@ -0,0 +1,19 @@
+export default {
+ 'skip-ssr': true,
+
+ data: {
+ foo: 'a'
+ },
+
+ test ( assert,... | <select value='{{value}}'> doesn't work as expected
[REPL](https://svelte.technology/repl?version=1.13.1&gist=24ef8e27a89761eafb7a0ea519cb9a84)
| null | 2017-03-29 23:18:25+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ignores-irrelevant-changes'... | ['generate inline helpers select-one-way-bind', 'generate shared helpers select-one-way-bind'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
sveltejs/svelte | 429 | sveltejs__svelte-429 | ['428'] | 38ee4f15cf2bacb4f6c16528442f7842c2791b9c | diff --git a/src/generators/dom/visitors/attributes/addElementAttributes.js b/src/generators/dom/visitors/attributes/addElementAttributes.js
--- a/src/generators/dom/visitors/attributes/addElementAttributes.js
+++ b/src/generators/dom/visitors/attributes/addElementAttributes.js
@@ -184,7 +184,7 @@ export default functi... | diff --git a/test/generator/samples/event-handler-custom-node-context/_config.js b/test/generator/samples/event-handler-custom-node-context/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/event-handler-custom-node-context/_config.js
@@ -0,0 +1,15 @@
+export default {
+ 'skip-ssr': true,
+
+ h... | Property in custom event handler
It's not working.
```html
<button on:customEventHandler='set({count: count + 1})'>1</button>
```
[REPL](https://svelte.technology/repl?version=1.13.2&gist=e69427bc8bca4b71760090dc4b49af26)
| null | 2017-03-30 09:03:26+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ignores-irrelevant-changes'... | ['generate inline helpers event-handler-custom-node-context', 'generate shared helpers event-handler-custom-node-context'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/visitors/attributes/addElementAttributes.js->program->function_declaration:addElementAttributes"] |
sveltejs/svelte | 438 | sveltejs__svelte-438 | ['436'] | a3ecb67977c6c25a3df3f0b50f2bba0e436bb856 | diff --git a/src/generators/dom/visitors/attributes/addElementBinding.js b/src/generators/dom/visitors/attributes/addElementBinding.js
--- a/src/generators/dom/visitors/attributes/addElementBinding.js
+++ b/src/generators/dom/visitors/attributes/addElementBinding.js
@@ -144,6 +144,11 @@ function getBindingValue ( gener... | diff --git a/test/generator/samples/binding-input-number/_config.js b/test/generator/samples/binding-input-number/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/binding-input-number/_config.js
@@ -0,0 +1,33 @@
+export default {
+ data: {
+ count: 42
+ },
+
+ html: `
+ <input type='number'>... | <input type='number' bind:value> — value should be a number
It makes no sense to treat `input.value` as a string if `input.type === 'number'`. The same goes for `range`.
| null | 2017-04-02 21:44:36+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'validate import-root', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ign... | ['generate shared helpers binding-input-number', 'generate inline helpers binding-input-range', 'generate inline helpers binding-input-number', 'generate shared helpers binding-input-range'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/visitors/attributes/addElementBinding.js->program->function_declaration:getBindingValue"] |
sveltejs/svelte | 439 | sveltejs__svelte-439 | ['437'] | a3ecb67977c6c25a3df3f0b50f2bba0e436bb856 | diff --git a/src/parse/read/directives.js b/src/parse/read/directives.js
--- a/src/parse/read/directives.js
+++ b/src/parse/read/directives.js
@@ -77,6 +77,17 @@ export function readBindingDirective ( parser, start, name ) {
const a = parser.index;
+ if ( parser.eat( '{{' ) ) {
+ let message = 'bound values s... | diff --git a/test/parser/samples/error-binding-mustaches/error.json b/test/parser/samples/error-binding-mustaches/error.json
new file mode 100644
--- /dev/null
+++ b/test/parser/samples/error-binding-mustaches/error.json
@@ -0,0 +1,8 @@
+{
+ "message": "bound values should not be wrapped — use 'foo', not '{{foo}}'",
+ ... | Helpful error for bind:value='{{foo}}'
I get caught out by this sometimes — you get an 'unexpected token' rather than 'oh, you don't need to use mustache tags with bindings'
| null | 2017-04-02 21:54:37+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'validate import-root', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ign... | ['parse error-binding-mustaches'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/parse/read/directives.js->program->function_declaration:readBindingDirective"] |
sveltejs/svelte | 443 | sveltejs__svelte-443 | ['431'] | 5c7bc411ec63fb7ad45c8dda422749e41ecd0565 | diff --git a/src/generators/dom/index.js b/src/generators/dom/index.js
--- a/src/generators/dom/index.js
+++ b/src/generators/dom/index.js
@@ -241,7 +241,7 @@ export default function dom ( parsed, source, options ) {
}
builders._set.addLine( 'var oldState = this._state;' );
- builders._set.addLine( 'this._state =... | diff --git a/test/generator/index.js b/test/generator/index.js
--- a/test/generator/index.js
+++ b/test/generator/index.js
@@ -30,6 +30,8 @@ require.extensions[ '.html' ] = function ( module, filename ) {
return module._compile( code, filename );
};
+const Object_assign = Object.assign;
+
describe( 'generate', ()... | todomvc is not working on old Android device
http://svelte-todomvc.surge.sh/#/ is not working on my Android 4.0.3 and is shown as follows:
I don't know which information should I deliver to help debuggi... | Thanks. My *hunch* is that it's because Svelte generates code that uses `Object.assign`, maybe that's not supported on the version of Chrome running on that device (is it Chrome? Or the Android browser that preceded it?)
If there's any way to get an error log by [remotely inspecting the browser](https://developers.g... | 2017-04-03 22:43:46+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'CodeBuilder adds newlines around blocks', 'formats cjs generates a CommonJS module', 'validate ondestroy-arrow-no-this', 'parse yield', 'parse attribute-unquoted', 'parse attribute-escaped', 'parse script', 'parse event-handler', 'parse script-comment-only', 'parse comment', '... | ['generate inline helpers component-ref', 'generate inline helpers select-one-way-bind', 'generate inline helpers each-blocks-nested-b', 'generate inline helpers binding-input-text-deep', 'generate inline helpers svg-attributes', 'generate inline helpers deconflict-builtins', 'generate inline helpers deconflict-templat... | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 2 | 0 | 2 | false | false | ["src/generators/dom/index.js->program->function_declaration:dom", "src/shared/index.js->program->function_declaration:assign"] |
sveltejs/svelte | 448 | sveltejs__svelte-448 | ['441'] | d105b6ba4c0d87ddb1ada58a0e7ba9fc76aafac6 | diff --git a/src/shared/methods.js b/src/shared/methods.js
--- a/src/shared/methods.js
+++ b/src/shared/methods.js
@@ -12,7 +12,7 @@ export function fire ( eventName, data ) {
}
export function observe ( key, callback, options ) {
- var group = ( options && options.defer ) ? this._observers.pre : this._observers.po... | diff --git a/test/generator/index.js b/test/generator/index.js
--- a/test/generator/index.js
+++ b/test/generator/index.js
@@ -135,14 +135,14 @@ describe( 'generate', () => {
assert.htmlEqual( target.innerHTML, config.html );
}
+ Object.assign = Object_assign;
+
if ( config.test ) {
conf... | Deferred observers on components should fire after DOM updates
[REPL](https://svelte.technology/repl?version=1.13.5&gist=583b4f3407d6fc72932a205b950cc136). Paste the following into the JSON editor:
```js
{
"message": "hello everybody!"
}
```
Expected result: the speech bubble adjusts its size immediately.
... | Not limited to nested components: https://svelte.technology/repl?version=1.13.5&gist=0ce36a578a1b96b8ea4f732e4dfa7647 | 2017-04-04 15:52:15+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'validate import-root', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ign... | ['generate shared helpers observe-deferred', 'generate inline helpers observe-deferred'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/shared/methods.js->program->function_declaration:observe"] |
sveltejs/svelte | 454 | sveltejs__svelte-454 | ['452'] | d105b6ba4c0d87ddb1ada58a0e7ba9fc76aafac6 | diff --git a/src/generators/dom/index.js b/src/generators/dom/index.js
--- a/src/generators/dom/index.js
+++ b/src/generators/dom/index.js
@@ -302,7 +302,7 @@ export default function dom ( parsed, source, options ) {
constructorBlock.addBlock( generator.builders.metaBindings );
}
- if ( templateProperties.comput... | diff --git a/test/generator/samples/computed-empty/_config.js b/test/generator/samples/computed-empty/_config.js
new file mode 100644
--- /dev/null
+++ b/test/generator/samples/computed-empty/_config.js
@@ -0,0 +1,8 @@
+export default {
+ html: '<div>empty</div>',
+ test ( assert, component, target ) {
+ assert.equal(... | Empty component 'computed' throws error.
An empty component `computed` property causes svelte compiler to add an unnecessary `recompute` call without actually adding the `recompute` function.
Version: 1.13.6
Smallest failing example:
```js
<script>
export default {
computed: {}
}
</script>
```
E... | I think allowing an empty `computed` object is reasonable. It looks like replacing the `templateProperties.computed` condition you mentioned with `computations.length` should fix this.
Great, I'll take care of that. | 2017-04-05 03:44:32+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'generate shared helpers inline-expressions', 'validate import-root', 'generate shared helpers if-block-elseif', 'generate shared helpers dev-warning-destroy-not-teardown', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'generate shared helpers observe-component-ign... | ['generate inline helpers computed-empty', 'generate shared helpers computed-empty'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/index.js->program->function_declaration:dom"] |
sveltejs/svelte | 464 | sveltejs__svelte-464 | ['451'] | 79c456333c255a8ae23acf02ed714b624cd1cca9 | diff --git a/src/generators/Generator.js b/src/generators/Generator.js
--- a/src/generators/Generator.js
+++ b/src/generators/Generator.js
@@ -39,7 +39,7 @@ export default class Generator {
// Svelte's builtin `import { get, ... } from 'svelte/shared.js'`;
this.importedNames = new Set();
this._aliases = new Ma... | diff --git a/test/validator/index.js b/test/validator/index.js
--- a/test/validator/index.js
+++ b/test/validator/index.js
@@ -69,4 +69,19 @@ describe( 'validate', () => {
});
}, /options\.name must be a valid identifier/ );
});
+
+ it( 'warns if options.name is not capitalised', () => {
+ const warnings = []... | <:Self> breaks for components whose name starts with a lowercase letter
Reproduction at https://github.com/TehShrike/svelte-self-repro
Component looks like:
```
<h1>{{heading}}</h1>
{{#if subheading}}
<:Self heading="{{subheading}}" />
{{/if}}
```
When the first letter of the component base name passed to... | Interesting. When using a component normally that begins with a lowercase letter, the component instance is correctly deconflicted from the class name. Maybe we need to add the component name passed through the `name` option to the compiler to the global list of names to avoid? And probably also that "Component names s... | 2017-04-10 22:44:05+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', 'ssr svg', 'runtime shared helpers names-deconflicted', 'r... | ['validate warns if options.name is not capitalised'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 3 | 0 | 3 | false | false | ["src/validate/js/propValidators/components.js->program->function_declaration:components", "src/validate/index.js->program->function_declaration:validate", "src/generators/Generator.js->program->class_declaration:Generator->method_definition:constructor"] |
sveltejs/svelte | 467 | sveltejs__svelte-467 | ['466'] | 92444ca0e11ff25a702eb5d5646709d02889c30e | diff --git a/src/generators/dom/visitors/Element/EventHandler.js b/src/generators/dom/visitors/Element/EventHandler.js
--- a/src/generators/dom/visitors/Element/EventHandler.js
+++ b/src/generators/dom/visitors/Element/EventHandler.js
@@ -44,7 +44,7 @@ export default function visitEventHandler ( generator, block, state... | diff --git a/test/generator/samples/computed-empty/_config.js b/test/runtime/samples/computed-empty/_config.js
similarity index 100%
rename from test/generator/samples/computed-empty/_config.js
rename to test/runtime/samples/computed-empty/_config.js
diff --git a/test/generator/samples/computed-empty/main.html b/test/r... | multiple method calls with different argument sequence
Iterating through a matrix with nested loops (i, j), the same method gets called twice with the arguments swapped depending on their relative values [REPL](https://svelte.technology/repl?version=1.13.7&gist=8ff2f390bf1cf85804108243f7fdfb31). Extract below.
{... | I think I know what's going on here — two event handlers are being created, but they're both being given the name `click_handler` rather than `click_handler` and `click_handler_1`. Fairly sure I know how to fix that... on it
| 2017-04-11 13:39:03+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', 'runtime inline helpers computed-empty', 'ssr svg', 'runti... | ['runtime inline helpers event-handler-each-deconflicted', 'runtime shared helpers event-handler-each-deconflicted'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/visitors/Element/EventHandler.js->program->function_declaration:visitEventHandler"] |
sveltejs/svelte | 471 | sveltejs__svelte-471 | ['470', '470'] | c54bebb75002e079262772cad5a856d82858760d | diff --git a/src/generators/dom/visitors/Element/Attribute.js b/src/generators/dom/visitors/Element/Attribute.js
--- a/src/generators/dom/visitors/Element/Attribute.js
+++ b/src/generators/dom/visitors/Element/Attribute.js
@@ -43,7 +43,7 @@ export default function visitAttribute ( generator, block, state, node, attribu... | diff --git a/test/runtime/samples/attribute-namespaced/_config.js b/test/runtime/samples/attribute-namespaced/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/attribute-namespaced/_config.js
@@ -0,0 +1,14 @@
+export default {
+ data: { foo: 'bar' },
+
+ html: `
+ <svg>
+ <use xlink:href="#bar... | Error: Unexpected token with dynamic SVG xhlink:href properties
Just tried to update my svelte to latest and started getting compilation errors.
Looks like a regression introduced in version `1.13.7`.
**Works:**
https://svelte.technology/repl?version=1.13.6&gist=b2df7e04cdacd4e8cf78e4678a69133a
**Compilation ... | Ah, yep, this is the code that's being generated:
<img width="472" alt="screen shot 2017-04-12 at 8 06 11 am" src="https://cloud.githubusercontent.com/assets/1162160/24956732/fff3aba2-1f56-11e7-9777-fd4e1757b404.png">
Ah, yep, this is the code that's being generated:
<img width="472" alt="screen shot 2017-04-12... | 2017-04-12 12:28:23+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['runtime shared helpers attribute-namespaced', 'runtime inline helpers attribute-namespaced'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/visitors/Element/Attribute.js->program->function_declaration:visitAttribute"] |
sveltejs/svelte | 473 | sveltejs__svelte-473 | ['166'] | ec543cf9b6e234b1f7e77011fa7e62056e8d1dda | diff --git a/src/utils/namespaces.js b/src/utils/namespaces.js
--- a/src/utils/namespaces.js
+++ b/src/utils/namespaces.js
@@ -5,4 +5,9 @@ export const xlink = 'http://www.w3.org/1999/xlink';
export const xml = 'http://www.w3.org/XML/1998/namespace';
export const xmlns = 'http://www.w3.org/2000/xmlns';
+export... | diff --git a/test/validator/samples/helper-purity-check-needs-arguments/input.html b/test/validator/samples/helper-purity-check-needs-arguments/input.html
new file mode 100644
--- /dev/null
+++ b/test/validator/samples/helper-purity-check-needs-arguments/input.html
@@ -0,0 +1,11 @@
+{{foo()}}
+
+<script>
+ export defau... | Help people distinguish between `methods` and `helpers`
It's not totally obvious what the distinction is between methods and helpers:
```html
<button on:click='myMethod()'>{{myHelper(foo)}}</button>
<script>
export default {
methods: {
myMethod () {
alert( 'called a method' );
}
... | The guide says "Helpers are simple functions that are used in your template." If that's the only distinction between methods and helpers, why not merge the concepts? What is gained by treating them separately?
They're conceptually very different things. Methods become part of the public API...
```js
import MyCompon... | 2017-04-12 15:42:35+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['validate helper-purity-check-needs-arguments', 'validate helper-purity-check-this-get', 'validate helper-purity-check-no-this', 'validate method-nonexistent', 'validate namespace-invalid', 'validate method-nonexistent-helper'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Feature | false | true | false | false | 8 | 0 | 8 | false | false | ["src/validate/js/propValidators/helpers.js->program->function_declaration:helpers->method_definition:enter", "src/validate/html/index.js->program->function_declaration:validateHtml->function_declaration:visit", "src/validate/js/propValidators/helpers.js->program->function_declaration:helpers", "src/validate/js/propVal... |
sveltejs/svelte | 477 | sveltejs__svelte-477 | ['475'] | ec543cf9b6e234b1f7e77011fa7e62056e8d1dda | diff --git a/src/generators/Generator.js b/src/generators/Generator.js
--- a/src/generators/Generator.js
+++ b/src/generators/Generator.js
@@ -148,7 +148,9 @@ export default class Generator {
});
dependencies.forEach( name => {
- this.expectedProperties.add( name );
+ if ( !globalWhitelist.has( name ) ) {
+... | diff --git a/test/runtime/samples/dev-warning-missing-data-binding/_config.js b/test/runtime/samples/dev-warning-missing-data-binding/_config.js
--- a/test/runtime/samples/dev-warning-missing-data-binding/_config.js
+++ b/test/runtime/samples/dev-warning-missing-data-binding/_config.js
@@ -1,7 +1,7 @@
export default {... | Change missing property errors to warnings?
After upgrading to the latest version of Svelte I was met with a bunch of `Component was created without expected data property 'whatever'` errors that broke my application.
It is not a huge amount of work to set default values for the properties using the `data()` method,... | Yep — I think it makes sense for this to be a warning
If you have a lot of components where you don't initially declare a data property, you'll lose out in terms of performance since the shape of the state object changes after it's initially created.
On a somewhat related note, I just noticed this:
```javascript
if... | 2017-04-12 22:58:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['runtime shared helpers dev-warning-missing-data-binding', 'runtime inline helpers dev-warning-missing-data', 'runtime inline helpers dev-warning-missing-data-binding', 'runtime shared helpers dev-warning-missing-data'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Feature | false | true | false | false | 2 | 0 | 2 | false | false | ["src/generators/dom/index.js->program->function_declaration:dom", "src/generators/Generator.js->program->class_declaration:Generator->method_definition:contextualise"] |
sveltejs/svelte | 478 | sveltejs__svelte-478 | ['476', '476'] | ef630b1483fccb4e1b97fd4a33877573c07d6050 | diff --git a/src/generators/dom/visitors/Element/Element.js b/src/generators/dom/visitors/Element/Element.js
--- a/src/generators/dom/visitors/Element/Element.js
+++ b/src/generators/dom/visitors/Element/Element.js
@@ -63,7 +63,7 @@ export default function visitElement ( generator, block, state, node ) {
.forEach( a... | diff --git a/test/runtime/samples/binding-select-late/_config.js b/test/runtime/samples/binding-select-late/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/binding-select-late/_config.js
@@ -0,0 +1,34 @@
+export default {
+ data: {
+ items: [],
+ selected: null
+ },
+
+ html: `
+ <select></s... | Select menu bind:value does not work to dynamically set options/values
I could have sworn this worked at some point, but I went back through different svelte versions and it seems to have always been an issue:
https://svelte.technology/repl?version=1.14.1&gist=155b2b84c2c9084986fd169a50c2b3dc
Changing the `bind:v... | 2017-04-12 23:59:38+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['runtime inline helpers binding-select-late', 'runtime shared helpers binding-select-late'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 1 | 0 | 1 | true | false | ["src/generators/dom/visitors/Element/Element.js->program->function_declaration:visitElement"] | |
sveltejs/svelte | 487 | sveltejs__svelte-487 | ['486', '486'] | cc21db37c322b37be29499156dcf6009a9fee7f3 | diff --git a/src/generators/dom/visitors/Element/Element.js b/src/generators/dom/visitors/Element/Element.js
--- a/src/generators/dom/visitors/Element/Element.js
+++ b/src/generators/dom/visitors/Element/Element.js
@@ -13,8 +13,8 @@ const meta = {
const order = {
Attribute: 1,
- EventHandler: 2,
- Binding: 3,
+ Bi... | diff --git a/test/runtime/samples/binding-input-with-event/_config.js b/test/runtime/samples/binding-input-with-event/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/binding-input-with-event/_config.js
@@ -0,0 +1,20 @@
+export default {
+ data: {
+ a: 42
+ },
+
+ test ( assert, component, targ... | 7guis example broken
Still trying to figure out exactly why, but adjusting the diameter in the 7guis circles example (click to create a circle, right-click to bring up the adjuster dialog) is broken:
* [1.13.6](https://svelte.technology/repl?version=1.13.6&example=7guis-circles) (works)
* [1.13.7](https://svelte.te... | It looks like this has to do with a single input element with both a `bind:` directive and an `on:` directive for the same event that calls `component.set`. A simple reproduction:
```html
<input bind:value='a' on:input='set({ b: 0 })'>
```
When an `input` event comes in, the `on:input` handler is called first. ... | 2017-04-16 18:22:05+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['runtime inline helpers binding-input-with-event', 'runtime shared helpers binding-input-with-event'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | true | false | false | false | 0 | 0 | 0 | false | false | [] |
sveltejs/svelte | 493 | sveltejs__svelte-493 | ['492', '492'] | 7f2dab6b4f9e9f16bf588305a9ffbb259835d9d1 | diff --git a/src/generators/Generator.js b/src/generators/Generator.js
--- a/src/generators/Generator.js
+++ b/src/generators/Generator.js
@@ -156,6 +156,8 @@ export default class Generator {
let scope = annotateWithScopes( expression );
const dependencies = [];
+ const generator = this; // can't use arrow fun... | diff --git a/test/runtime/samples/dev-warning-helper/_config.js b/test/runtime/samples/dev-warning-helper/_config.js
new file mode 100644
--- /dev/null
+++ b/test/runtime/samples/dev-warning-helper/_config.js
@@ -0,0 +1,11 @@
+export default {
+ dev: true,
+
+ data: {
+ bar: 1
+ },
+
+ html: '2',
+
+ warnings: []
+};
... | Warnings in dev mode showing up for helper functions in version 1.16.0
This seems like a regression in version 1.16.0. I can’t reproduce it on the REPL (since it doesn’t run in dev mode).
As an example I have a component that looks like this
```html
<div id="time" maxwidth="8">{{ timeToDisplayTime(time) }}</div... | The obvious way to address this is to add a `!this.helpers.has( name )` condition before adding `name` to `this.expectedProperties`. But I'm not sure whether that would be missing some subtler thing. Should the helper be in the dependencies at all? Do we need special handling in the case where someone has an `{{#each}}... | 2017-04-18 12:33:12+00:00 | JavaScript | FROM polybench_javascript_base
WORKDIR /testbed
COPY . .
RUN . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && rm -rf node_modules && npm pkg set scripts.lint="echo noop" && npm install
RUN . $NVM_DIR/nvm.sh && nvm alias default 16.20.2 && nvm use default
| ['parse binding', 'validate import-root', 'runtime shared helpers event-handler-each-deconflicted', 'ssr component', 'formats cjs generates a CommonJS module', 'ssr each-block-else', 'validate ondestroy-arrow-no-this', 'runtime inline helpers if-block-elseif-text', 'runtime inline helpers helpers', 'sourcemaps basic', ... | ['runtime shared helpers dev-warning-helper', 'runtime inline helpers dev-warning-helper'] | null | . /usr/local/nvm/nvm.sh && nvm use 16.20.2 && npm pkg set scripts.lint="echo noop" && npm run test -- --reporter json --exit | Bug Fix | false | true | false | false | 5 | 0 | 5 | false | false | ["src/shared/dom.js->program->function_declaration:setAttribute", "src/generators/Generator.js->program->class_declaration:Generator->method_definition:findDependencies", "src/shared/dom.js->program->function_declaration:addEventListener", "src/shared/dom.js->program->function_declaration:removeEventListener", "src/gen... |
Subsets and Splits
Top Repos by Test Count
Lists the top 1000 repositories by the number of entries, providing a basic count of entries per repository.
Unique Repo Selection
Lists unique repository names from the dataset, providing a basic overview of the repositories present.